fix(cssc): 31670352 Upgrade oras-py package to use new auth flow 2/n#41
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the oras package to version 0.2.25 to implement the new authentication flow and avoid the "empty token" error when authenticating to the registry. Key changes include updating the dependency in setup.py and modifying the artifact pull and login flow in _ociartifactoperations.py.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/acrcssc/setup.py | Upgraded the oras dependency from 0.1.19 to 0.2.25 |
| src/acrcssc/azext_acrcssc/helper/_ociartifactoperations.py | Adjusted the artifact pull parameter and updated the client login |
Comments suppressed due to low confidence (1)
src/acrcssc/azext_acrcssc/helper/_ociartifactoperations.py:87
- Replacing 'stream=True' with 'overwrite=True' changes the behavior of oras_client.pull. Please confirm that this change is intentional and aligns with the new package's API.
overwrite=True
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the oras package to version 0.2.25 to adopt the new authentication flow and avoid the "empty token" error, while updating related client invocations to support the new parameters.
- Upgrades oras dependency in setup.py
- Updates oras_client.pull to use overwrite=True instead of stream=True
- Adds an auth_backend parameter and debug logging in the OrasClient initialization
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/acrcssc/setup.py | Upgraded oras dependency version to support new auth flow |
| src/acrcssc/azext_acrcssc/helper/_ociartifactoperations.py | Adjusted oras client parameters and added debug logging |
Comments suppressed due to low confidence (2)
src/acrcssc/azext_acrcssc/helper/_ociartifactoperations.py:87
- Replacing 'stream=True' with 'overwrite=True' in oras_client.pull alters the artifact retrieval behavior; please verify this change supports the intended functionality of the new auth flow.
overwrite=True
src/acrcssc/azext_acrcssc/helper/_ociartifactoperations.py:128
- Ensure that introducing the auth_backend parameter with value 'token' to OrasClient is fully supported by the new oras version and does not disrupt other authentication mechanisms.
client = OrasClient(hostname=str.lower(registry.login_server), auth_backend="token")
cegraybl
changed the title
mabelegba
pushed a commit
that referenced
this pull request
Nov 25, 2025
* Upstream Merge * Merge from workload-orchestration : Added Example in Description (#34) * Merge from workload-orchestration : Fixed Example * Fixed Example for SolutionTemplateVersion * Made Changes for command-change CI fix' * Reset Version 1.0.0b1 * Added Bulk and Diagnostics Back (#35) Co-authored-by: Atharva Udapure <audapure@microsoft.com> * Added Bulk Solution Example (#36) * Added Bulk and Diagnostics Back * Changes --------- Co-authored-by: Atharva Udapure <audapure@microsoft.com> * Fixed Solution Template Linter Issue * Added Integration Tests Framework for WorkloadOrchestration #37 Co-authored-by: Atharva Udapure <audapure@microsoft.com> * Added ServiceName (#38) * Added Tests * Made Changes on ServiceName --------- Co-authored-by: Atharva Udapure <audapure@microsoft.com> * Added Full Target Solution Tests (#39) * Added Tests * Made Changes on ServiceName * Nit Changes * Made Changes for ContextLookup --------- Co-authored-by: Atharva Udapure <audapure@microsoft.com> * Added E2E workflow Tests (#40) * Added Tests * Made Changes on ServiceName * Nit Changes * Made Changes for ContextLookup * Added complete workflow * Add Licence * Added License --------- Co-authored-by: Atharva Udapure <audapure@microsoft.com> * Added Readme (#41) Co-authored-by: Atharva Udapure <audapure@microsoft.com> * Bulk Deployemnent LRO changes (#42) * made changes * Added change * Added Changes in Test * Added CLi Changes * Added Setup --------- Co-authored-by: Atharva Udapure <audapure@microsoft.com> * Added Changes For Backward Compitablity (#43) * Added Changes For Backward Compitablity * Made changes --------- Co-authored-by: Atharva Udapure <audapure@microsoft.com> * Made changes (#44) Co-authored-by: Atharva Udapure <audapure@microsoft.com> * Target Operations API refractoring (#47) * Changes I made * Make changes * Made chnages * Make changes --------- Co-authored-by: Atharva Udapure <audapure@microsoft.com> * Stable API 2025-06-01 (#48) * Made changes * Made Changes --------- Co-authored-by: Atharva Udapure <audapure@microsoft.com> * Change in ID in Targets (#50) * Made changes * changes --------- Co-authored-by: Atharva Udapure <audapure@microsoft.com> * Remove Id and Name from Target Review (#51) Co-authored-by: Atharva Udapure <audapure@microsoft.com> * final bulk (#52) Co-authored-by: Atharva Udapure <audapure@microsoft.com> * Changes in ARG * Added Linter Exception * Added ITTests (#53) Co-authored-by: Atharva Udapure <audapure@microsoft.com> * Standardize CLI (#54) * Made Changes * Made Changes * Made changes * Added Change * Made changes * Made changes * Made changes * Made Changes --------- Co-authored-by: Atharva Udapure <audapure@microsoft.com> * Linter FIxes and Remove Preview * Removed Resolved from CLI * change in version * made changes (#55) Co-authored-by: Atharva Udapure <audapure@microsoft.com> * Fixed history --------- Co-authored-by: Atharva Udapure <audapure@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is a continuation of the changes in PR 39
Updates the
oraspackages to 0.2.25 to use a more recent version of the package to avoid the "empty token" error when authenticating to the registry.