Skip to content

fix(cssc): 31250186 address all comments in public repo PR#42

Closed
cegraybl wants to merge 436 commits into
feature/cssc_extfrom
cegraybl/official_pr_comments
Closed

fix(cssc): 31250186 address all comments in public repo PR#42
cegraybl wants to merge 436 commits into
feature/cssc_extfrom
cegraybl/official_pr_comments

Conversation

@cegraybl
Copy link
Copy Markdown

@cegraybl cegraybl commented Apr 8, 2025

This change addresses all the comments in the public repo PR.
Final change for public preview.
Test passes, lint and style are successful.

ABZhang0 and others added 30 commits November 5, 2024 14:35
@ABZhang0
prevent folder import (Azure#8207)
fd7b4a6 
Co-authored-by: Alan Zhang <alanzhang@microsoft.com>
@azclibot
[Release] Update index.json for extension [ amg ]
4b8cff6 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/release/_build/results?buildId=203447&view=results

Last commit: Azure@fd7b4a6
@annapankiewicz
Update networkcloud 2024-07-01 to ensure compatibility with Python 3.…
3a563c9 
…12 (Azure#8215)

Co-authored-by: Anna Pankiewicz <anna.pankiewicz@microsoft.com>
@azclibot
[Release] Update index.json for extension [ networkcloud ]
606ed70 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/release/_build/results?buildId=203456&view=results

Last commit: Azure@3a563c9
@Greedygre
[Containerapp] az containerapp create/update: --yaml support prop…
8005294 
…erty pollingInterval and cooldownPeriod (Azure#8236)
@evelyn-ys
Remove db-up (Azure#8231)
27d49e3
@cxznmhdcxz
{azure-firewall} Remove ADAL dependencies (Azure#8230)
340ec15 
* remove msrest utils

* update version
@azclibot
[Release] Update index.json for extension [ azure-firewall ]
98b80d6 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/release/_build/results?buildId=203548&view=results

Last commit: Azure@340ec15
@alexmahonic
Bump up extension version (Azure#8241)
66eb468 
Co-authored-by: Hong Ma <hongma@microsoft.com>
@azclibot
[Release] Update index.json for extension [ multicloud-connector ]
9600540 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/release/_build/results?buildId=203816&view=results

Last commit: Azure@66eb468
@bingosummer
[AKS] BREAKING CHANGE: az aks create: Remove AAD-legacy properties …
b990860 
…`--aad-client-app-id`, `--aad-server-app-id` and `--aad-server-app-secret` when creating cluster (Azure#8228)
@azclibot
[Release] Update index.json for extension [ aks-preview ]
31f65e7 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/release/_build/results?buildId=203878&view=results

Last commit: Azure@b990860
@joal42
{compute-diagnostic} Remove az compute-diagnostic command group (Azur…
fd07500 
…e#8240)

* Delete src/compute-diagnostic-rp directory

* Update service_name.json

* remove compute-diagnostic from index.json
@rayaisaiah
[AKS] BREAKING CHANGE: Update ACNS preview CLI commands to align with…
63a3ae8 
… GA CLI (Azure#8217)
@azclibot
[Release] Update index.json for extension [ aks-preview ]
4a7218c 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/release/_build/results?buildId=204097&view=results

Last commit: Azure@63a3ae8
@mukhoakash
AKS: Fix storage pool name validation for Azure Container Storage (Az…
7464d03 
…ure#8233)
@azclibot
[Release] Update index.json for extension [ aks-preview ]
c474110 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/release/_build/results?buildId=204174&view=results

Last commit: Azure@7464d03
@wangzelin007
{CI} Disable persist credentials (Azure#8245)
8021435
@Himanshu49
[Azure Load Testing] Adding disable-public-ip argument in load extens…
3477cfa 
…ion (Azure#8239)

* Adding support for publicIPDisabled

* Added test cases for public ip disabled param

* Changing version from 1.1.2 to 1.2.0 as its minor changes and not patch

* nit: condition refactoring and pushing new recordings

* added more test cases

* nit: fixing CI failures
@azclibot
[Release] Update index.json for extension [ load ]
22766ce 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/release/_build/results?buildId=204207&view=results

Last commit: Azure@3477cfa
@YitongFeng-git
[AKS] BREAKING CHANGE: az aks trustedaccess rolebinding create: Rem…
2e3be93 
…ove deprecated `-r` and `-s` options (Azure#8243)
@azclibot
[Release] Update index.json for extension [ aks-preview ]
0cc00fe 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/release/_build/results?buildId=204223&view=results

Last commit: Azure@2e3be93
@Jing-song
{Image-copy} Remove direct call to msrestazure (Azure#8232)
96fdc9c
@azclibot
[Release] Update index.json for extension [ image-copy ]
58f0536 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/release/_build/results?buildId=204257&view=results

Last commit: Azure@96fdc9c
@liorstauber @t-lstauber
API mismatch fix (Azure#8247)
75b87ec 
Co-authored-by: Lior Stauber <t-lstauber@microsoft.com>
@FumingZhang
update (Azure#8254)
a719b25
@SethHollandsworth @ksayid
[confcom] adding fragment support (Azure#8238)
7d4644e 
* read only logic for some mount types (#62)

* offloading error checking and updating tests

* Gracefully handle broken base64 policies in non-diff mode (#64)

* handle broken base64
* address style fixes

* adding flag to omit ID from policy

* adding ability to not use sidecars via ARM tag

* adding workload identity support for vn2

* Add user prompt to confirm policy overwrite for VN2 YAMLs

* support for image attached fragments

* updating locations where executables are found

* updating version to 1.1.0

* updating test value

* taking out unused dependency

* fixing errors in docs and types

* getting rid of whitespace

* updating kata tests for linux

* updating kata tests for windows

* can't have binary files

---------

Co-authored-by: Khalil Sayid <30742855+ksayid@users.noreply.github.com>
Co-authored-by: Khalil Sayid <khalilsayid@microsoft.com>
@azclibot
[Release] Update index.json for extension [ confcom ]
f52ad8c 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/release/_build/results?buildId=204793&view=results

Last commit: Azure@7d4644e
@danlope
AVNM, IPAM, VNV updates for 2024-05-01 swagger (Azure#8187)
278bd87 
* Updating resource name regex pattern to latest

* sec admin config and rule updates

* Update version in HISTORY.rst

* Updated version in setup.py

* resolve missing_parameter_help

* passed tests

* marked stable

* change version from 1.3.0 to 1.4.0 to try and resolve CI error 'release-version-block'

* updating version to expected 1.3.1
@azclibot
[Release] Update index.json for extension [ network-manager ]
cd39847 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/release/_build/results?buildId=204930&view=results

Last commit: Azure@278bd87
xmzhao0822 and others added 25 commits February 6, 2025 10:45
@xmzhao0822
{AKS} xmzhao/update outboundtype automatic (Azure#8446)
1c70844
@azclibot
[Release] Update index.json for extension [ aks-preview-13.0.0b3 ]
ba3e6c7 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=114435406&view=results

Last commit: Azure@1c70844
@zhangjacq
add support for bastion developer create (Azure#8366)
d2c93aa 
* add support for bastion developer create

* space-separated ip addresses for network acls

* add history

* features vars naming

* check fix

* re-record tests

* attempt to fix api-version for vnet PUT

* update recording

---------

Co-authored-by: Jacques Zhang <zhangja@microsoft.com>
@azclibot
[Release] Update index.json for extension [ bastion-1.4.0 ]
df75dba 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=114437701&view=results

Last commit: Azure@d2c93aa
@bavneetsingh16
[connectedk8s] Update extension CLI to v1.10.5 (Azure#8454)
aa7431b
@azclibot
[Release] Update index.json for extension [ connectedk8s-1.10.5 ]
775f2fb 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=114449774&view=results

Last commit: Azure@aa7431b
@dbradish-microsoft
Update service_name.json | remove old mappings (Azure#8455)
6d1a5e3
@pachaturvedi
Remove Logz reference from index.json (Azure#8459)
48772cc
@zjpjack-github
fix 'az aks nodepool upgrade' cannot set 'node-soak-duration' to 0 (A…
a3f7316 
…zure#8443)
@azclibot
[Release] Update index.json for extension [ aks-preview-13.0.0b4 ]
c5eb3c6 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=114573497&view=results

Last commit: Azure@a3f7316
@clnv
[AKS] az aks create/az aks nodepool add: Emit error message when us…
d344335 
…ing `--asg-ids` alone without `--allowed-host-ports` (Azure#8456)
@azclibot
[Release] Update index.json for extension [ aks-preview-13.0.0b5 ]
c5e2b07 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=114577049&view=results

Last commit: Azure@d344335
@dbradish-microsoft
Update list-template.md | fix metadata to conform to new guidelines (A…
8cc7f6d 
…zure#8368)

* Update list-template.md | fix metadata to conform to new guidelines

According to the allowed values for `ms.topic` as now showing in the Contributor's Guide (https://review.learn.microsoft.com/en-us/help/platform/metadata-taxonomies/mstopic?branch=main), the ms.topic for autogenerated reference content should be `language-reference`. By making this update, the available extensions report will also be removed from management's broken link report. We'll still be able to monitor broken links from the azure-docs-cli repo's daily build report.

* Update ms.topic to generated-reference
@saisankargochhayat
Update download URL for CLI 1.0.0 (Azure#8449)
c8027e7 
Co-authored-by: Sai Sankar Gochhayat <sgochhayat@microsoft.com>
@wiboris
{batch} removing batch cli extensions (Azure#8468)
9afada9
@am-lim @ericaguthan
[devcenter] Fix syntax error with schedule commands (Azure#8457)
f684127 
* Update project env type parameters

* Fix environment def example and update style

* Fix show logs

* Fix spacing

* Fix style error

* Fix integraion tests

* Fix gallery test

* Fix gallery test

* Fix gallery compute

* Update

* Update control plane

* Update tests and vendored sdk for data plane API

* Updates

* Update tests

* Update version

* Update tests

* Update log command to support escape characters

* Update control plane to 2024-10-01-preview

* Changes for force delete only

* update api version

* remove preview flag

* Fix linter errors

* Update control plane tests

* Update tests

* Update commands

* Add project policy test

* Update

* add missing override

* Update response

* Add tests

* Fix image name regex

* Update version for Ignite

* Update data plane tests

* Update control plane tests

* Fix control plane tests

* Fix nsg

* Update params

* Update release version

* Update data plane 2024-10-01-preview

* Remove old dp code

* Add devbox list

* Add project,pool,schedule

* Add devbox

* Fix post, add snapshots

* Fix post LRO

* Add environments

* Add additional cmds

* Fix help

* Fix params

* Fix customization task validate

* Linter and style fixes

* Update version

* Update version2

* Update dp tests

* Add dev box tests

* Add repair test

* Add snapshot test

* Add customization task  test

* Add customization group  test

* Add environment  test

* Update tests

* Update help

* Fix tests

* Fix examples and show logs output

* Handle if there is no next scheduled time

* Update HISTORY.rst

* Fix syntax errors

* Update version

---------

Co-authored-by: Erica Guthan <ericaguthan@microsoft.com>
@azclibot
[Release] Update index.json for extension [ devcenter-6.2.3 ]
7b5fddb 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=114851450&view=results

Last commit: Azure@f684127
@mabelegba
Azure Pipeline configuration
8702851
@cegraybl
Merge branch 'feature/cssc_ext', commit '870285134b8502586eb336d67521…
3d46df8 
…ddba08d533f1' of https://github.com/AzureCR/azure-cli-extensions into feature/cssc_ext
@cegraybl
first wave of review comments
7b5f5bf
@cegraybl
handle files using 'with' directive and fix unit test
f16fa38
@cegraybl
simplify some path handling, remove unused code from _taskoperations
41266fb
@cegraybl
change call for 'workflow show' change call to 'list' to 'get' using …
f96f2b1 
…known task names
@cegraybl
fix style issue
a47f47a
@cegraybl
rerun live test
a686b19
@cegraybl cegraybl force-pushed the cegraybl/official_pr_comments branch from 8fa9d81 to a686b19 Compare April 8, 2025 23:19
@cegraybl
Copy link
Copy Markdown
Author

cegraybl commented Apr 8, 2025

messed up something in my branch history, will recreate

@cegraybl cegraybl closed this Apr 8, 2025
@cegraybl cegraybl deleted the cegraybl/official_pr_comments branch April 23, 2025 17:11
mabelegba pushed a commit that referenced this pull request Nov 25, 2025
@atharvau
{Workload-orchestration} Initial CLI Extension Release (Azure#8773)
8a62c75 
* Upstream Merge

* Merge from workload-orchestration : Added Example in Description (#34)

* Merge from workload-orchestration : Fixed Example

* Fixed Example for SolutionTemplateVersion

* Made Changes for command-change CI fix'

* Reset Version 1.0.0b1

* Added Bulk and Diagnostics Back (#35)

Co-authored-by: Atharva Udapure <audapure@microsoft.com>

* Added Bulk Solution Example (#36)

* Added Bulk and Diagnostics Back

* Changes

---------

Co-authored-by: Atharva Udapure <audapure@microsoft.com>

* Fixed Solution Template Linter Issue

* Added Integration Tests Framework for WorkloadOrchestration #37

Co-authored-by: Atharva Udapure <audapure@microsoft.com>

* Added ServiceName  (#38)

* Added Tests

* Made Changes on ServiceName

---------

Co-authored-by: Atharva Udapure <audapure@microsoft.com>

* Added Full Target Solution Tests (#39)

* Added Tests

* Made Changes on ServiceName

* Nit Changes

* Made Changes for ContextLookup

---------

Co-authored-by: Atharva Udapure <audapure@microsoft.com>

* Added E2E workflow Tests (#40)

* Added Tests

* Made Changes on ServiceName

* Nit Changes

* Made Changes for ContextLookup

* Added complete workflow

* Add Licence

* Added License

---------

Co-authored-by: Atharva Udapure <audapure@microsoft.com>

* Added Readme (#41)

Co-authored-by: Atharva Udapure <audapure@microsoft.com>

* Bulk Deployemnent LRO changes (#42)

* made changes

* Added change

* Added Changes in Test

* Added CLi Changes

* Added Setup

---------

Co-authored-by: Atharva Udapure <audapure@microsoft.com>

* Added Changes For Backward Compitablity (#43)

* Added Changes For Backward Compitablity

* Made changes

---------

Co-authored-by: Atharva Udapure <audapure@microsoft.com>

* Made changes (#44)

Co-authored-by: Atharva Udapure <audapure@microsoft.com>

* Target Operations API refractoring  (#47)

* Changes I made

* Make changes

* Made chnages

* Make changes

---------

Co-authored-by: Atharva Udapure <audapure@microsoft.com>

* Stable API 2025-06-01 (#48)

* Made changes

* Made Changes

---------

Co-authored-by: Atharva Udapure <audapure@microsoft.com>

* Change in ID in Targets (#50)

* Made changes

* changes

---------

Co-authored-by: Atharva Udapure <audapure@microsoft.com>

* Remove Id and Name from Target Review  (#51)

Co-authored-by: Atharva Udapure <audapure@microsoft.com>

* final bulk (#52)

Co-authored-by: Atharva Udapure <audapure@microsoft.com>

* Changes in ARG

* Added Linter Exception

* Added ITTests (#53)

Co-authored-by: Atharva Udapure <audapure@microsoft.com>

* Standardize CLI (#54)

* Made Changes

* Made Changes

* Made changes

* Added Change

* Made changes

* Made changes

* Made changes

* Made Changes

---------

Co-authored-by: Atharva Udapure <audapure@microsoft.com>

* Linter FIxes and Remove Preview

* Removed Resolved from CLI

* change in version

* made changes (#55)

Co-authored-by: Atharva Udapure <audapure@microsoft.com>

* Fixed history

---------

Co-authored-by: Atharva Udapure <audapure@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.