Merged
Conversation
After BVLC#1172, some cuDNN pooling layer tests were failing due to use of padding. (Before BVLC#1172, these tests were actually testing PoolingLayer instead of CuDNNPoolingLayer via the fallback.) This commit disables many tests via commenting, so that they can be easily readded when cuDNN gains pooling padding support.
Contributor
Author
|
As this is now passing Travis and restores cuDNN dev to passing, I'll take the liberty of merging it immediately. |
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
Fix cuDNN pooling tests
Merged
RazvanRanca
pushed a commit
to RazvanRanca/caffe
that referenced
this pull request
Nov 4, 2014
Fix cuDNN pooling tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1172 broke cuDNN pooling tests in dev. Actually, cuDNN pooling tests were largely testing Caffe's
PoolingLayerdue to the padding fallback before #1172. These commits comment the cuDNN pooling tests that rely on padding, and modify the ones that used it but didn't need it.I've checked that this passes build, lint, warn, and runtest with
USE_CUDNN. For now, let's remember tomake everythingor equivalent when merging changes to cuDNN.