Data_layer (#1933) update and URI sources#2351
Conversation
|
Wow, that's a long patch! It's difficult to review all of these changes at once. I didn't look at the details, but I have the feeling you are adding multiple orthogonal features in a single patch.
I'm not a Caffe maintainer, but I feel all those features should be separate PRs, or at least separate patches. For 5) and 6+), I imagine you could first do a PR for URI sources, then a PR for multiple sources, then a PR for probabilities on the sources, etc. It would make each PR shorter and thus easier to review. I think a lot of developers are currently afraid by this huge patch and don't want to spend the time to review it :) |
|
@flx42, thanks for your analysis. Actually we just now had an in-person meeting with @cypof and I think we agree totally with your points; this will be refactored into smaller PRs for review. Regarding point 4, check out #2067, which is my cut-and-paste of @cypof's code (which I'm also using for #2219). That's due to be merged soon and your comments are welcome. |
|
Has been split in the referenced PRs. |
This PR is meant to replace #1933. It has the same features, with a lot of cleaning, a consistent way to initialize random seeds between threads, and a better separation between prefetching and data_layer code. Also some dependencies are now optional.