Closed
Conversation
cypof
force-pushed
the
persistent_prefetch_thread
branch
from
2d47a62 to
0d21029
Compare
cypof
force-pushed
the
persistent_prefetch_thread
branch
from
0d21029 to
2f439ac
Compare
|
Regarding the vector: do you mean using a If so, I would favor that option. An example use case for this would be custom data layers that expose more than 2 tops. I'm currently working on such a data layer for my research, and might be able to help with the change. (Though I'm still new to caffe.) |
- Interrupt the thread before waiting on join - Provide a method for looping threads to exit on demand - CHECK if start and stop succeed instead of returning an error
cypof
force-pushed
the
persistent_prefetch_thread
branch
from
2f439ac to
01cbda5
Compare
Closed
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2351. Makes sure the prefetch thread for data_layer is created only once, instead of for each batch. We discussed about switching to vector instead of Batch, which would probably be easy but I haven't looked at it.