im2col with hole#3232
Closed
tamakoji wants to merge 10 commits intoBVLC:masterfrom
tamakoji:im2col_with_holes
Closed
im2col with hole#3232tamakoji wants to merge 10 commits intoBVLC:masterfrom tamakoji:im2col_with_holes
tamakoji wants to merge 10 commits intoBVLC:masterfrom
tamakoji:im2col_with_holes
Conversation
…fit on current caffe implementation.
|
👍 |
__CUDA_ARCH__ is not defined in host code; the #if was vacuous and misleading.
Remove dead preprocessor code for number of CUDA threads
[build] Display and store cuDNN version numbers for CMake
don't divide by 0 duration when downloading model binary
Remove hamming_distance and popcount
|
@tamakoji Would you please rebase this PR with the current caffe? |
added 2 commits
December 3, 2015 18:49
…fit on current caffe implementation.
Conflicts: include/caffe/vision_layers.hpp
Author
|
@llllaaaa done. |
|
@tamakoji Thanks a lot! @shelhamer Could you merge this into the master branch? I think it is a very useful feature |
Author
|
there are lots of lint errors(mostly exceeding 80chars), do I need to fix them? |
|
@tamakoji Thank you for your works, but the code cannot run in the cudnn mode. What should I do to make the code support cudnn? |
|
@GoYchen cudnn does not use im2col, and does not support holes |
|
@llllaaaa Thank you very much for your answer. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported algorithm of George Papandreou(DeepLab)' im2col with hole to fit on current caffe
implementation. variable name "hole" been modified to 'kernel_stride" which make more sense than
hole, since hole = 1 does not have hole, its just kernel stride.
modified test_im2col_kernel.cu and verified(tested test_im2col_kernel and test_im2col_layer).