Fix ImageDataLayer's silent failure on file paths with spaces #3433
Closed
bchu wants to merge 1 commit intoBVLC:masterfrom
Closed
Fix ImageDataLayer's silent failure on file paths with spaces #3433bchu wants to merge 1 commit intoBVLC:masterfrom
bchu wants to merge 1 commit intoBVLC:masterfrom
Conversation
…tting on last space. Also fixes its test to contain newlines. Fixes BVLC#1935.
bchu
force-pushed
the
filename_whitespace
branch
from
3da69d5 to
47962e0
Compare
Contributor
Author
|
I realized that the issue is already fixed by: #1971, so I closed this PR. Re-opening in case people think it's a good idea. This method is less forgiving than the regex method, with the sole benefit of avoiding a dependency on boost regex. |
|
I would be happy to see this fix merged since we ran into this problem while using caffe in our group at work. With that said, it'd be nice to use a comma or something that's more robust than just a space as a separator. |
Contributor
Author
|
Resolved by #4059 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by splitting on last space.
Also fixes its test to contain newlines. Fixes #1935 and #1951.
Note: I don't work with C++ very much, so please let me know if there's a better way of doing this.
I've also changed window_data_layer and hdf5_data_layer to read in lines. Please check that this is correct (I have never used hdf5 or window_data).