Add support for specifying a separator in the image data layer#4203
Closed
elezar wants to merge 3 commits intoBVLC:masterfrom
Closed
Add support for specifying a separator in the image data layer#4203elezar wants to merge 3 commits intoBVLC:masterfrom
elezar wants to merge 3 commits intoBVLC:masterfrom
Conversation
Contributor
Author
Contributor
|
This looks really clean, and the tests are nice. Great work! @flx42 @longjon @shelhamer want to take a look? |
Contributor
Contributor
Author
|
Thanks for taking a look. The combination of the two commits probably makes |
elezar
force-pushed
the
feature/label_separator
branch
from
a87bdc2 to
ffd521c
Compare
added 3 commits
June 1, 2016 07:51
- Add a separator to the proto definition. - Add a test for a separator that is too long. - Added a comma-separated test.
elezar
force-pushed
the
feature/label_separator
branch
from
ffd521c to
0925d9a
Compare
Contributor
Author
|
@flx42 I have rebased the commits (and onto the current master) as requested. I hope that everything is in order now. |
Contributor
Author
|
Any update on this? Would be great to get this merged and closed! |
Contributor
Author
|
Closing this PR as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although #3653 has been open for a while now, I noticed that #4059 (which adds support for file names with spaces in) means that my implementation may require a little more work. I therefore thought that I would break things up into multiple PRs so that I can get a better grip on the changes required.
This PR will add support for a specifying a separator (e.g. a comma) instead of assuming a space-separated list. This was also mentioned in #3433 (comment).
I have also restructured the test class somewhat to make it easier to write tests for the image data layer.