Shape mismatch CHECK logging improvements#5545
Merged
Noiredd merged 1 commit intoBVLC:masterfrom Feb 2, 2018
Merged
Conversation
brunobowden
force-pushed
the
shape_mismatch_checks
branch
2 times, most recently
from
a0a0f0a to
b3c5f9d
Compare
brunobowden
force-pushed
the
shape_mismatch_checks
branch
from
b3c5f9d to
7b5ad4a
Compare
Contributor
Author
|
Seeing flaky build failures in |
- More logs when shapes mismatch
- Manual reviewed all matches of “grep -r CHECK.*shape src”
- Follow JUnit convention of:
```
CHECK(expected == actual)
<< “expected: “ << expected
<< “ vs. actual: ” << actual;
```
Layers:
- Recurrent
- BaseConvolutionLayer
- Slice (improves logging for incorrect parameter)
CHECK_EQ
- Would prefer to use CHECK_EQ(expected, actual):
https://github.com/google/glog/blob/master/src/glog/stl_logging.h.in#L36
- However this requires include of stl_logging.h which introduces a
build warning. I believe this would work if caffe was updated to the
latest version of glog but that's a bigger change.
brunobowden
force-pushed
the
shape_mismatch_checks
branch
from
7b5ad4a to
fb0795c
Compare
Member
|
Merging. Thank you for the definite improvement! Also, the randomly failing build has been solved in #5973. |
XinYao1994
pushed a commit
to XinYao1994/caffe
that referenced
this pull request
Aug 29, 2018
Shape mismatch CHECK logging improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layers:
CHECK_EQ
https://github.com/google/glog/blob/master/src/glog/stl_logging.h.in#L36
build warning. I believe this would work if caffe was updated to the
latest version of glog.