Add absolute tolerance to test_net.py to prevent random Travis fails#5973
Merged
Noiredd merged 1 commit intoBVLC:masterfrom Oct 19, 2017
Merged
Add absolute tolerance to test_net.py to prevent random Travis fails#5973Noiredd merged 1 commit intoBVLC:masterfrom
Noiredd merged 1 commit intoBVLC:masterfrom
Conversation
Member
|
LGTM |
Member
Author
I explained that in the comment under the issue itself. This test does not only concern randomly generated data, but also weights in the InnerProduct layer of the test net. We can increase the data slightly but the weights (drawn from a normal distribution) can still roll such that some output will be small. |
Member
|
@Noiredd what holds you from merging this PR? |
Member
|
Thanks for addressing these spurious flaky tests! |
This was referenced Nov 2, 2017
Merged
This was referenced Feb 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on issue #5960 - fix by adding absolute tolerance of
1e-5totest_forward_start_end()andtest_backward_start_end()intest_net.py. I iteratedpython -m unittest discover -s caffe/test -p "test_net.py"over the current master 500 times and no random fails occurred.Additionally I removed semicolons that ended each line in those two functions - it looked weird.