Skip to content

Comments

Fix default mode warning in io.resize_image#5969

Merged
Noiredd merged 1 commit intoBVLC:masterfrom
developius:fix-default-mode-warning
Nov 2, 2017
Merged

Fix default mode warning in io.resize_image#5969
Noiredd merged 1 commit intoBVLC:masterfrom
developius:fix-default-mode-warning

Conversation

@developius
Copy link
Contributor

Signed-off-by: Finnian Anderson get@finnian.io

This fixes a warning in io.resize_image which originates in skimage.transform.resize.
The default mode for resize will change from constant to reflect, so this commit changes the call to resize so that it passes mode manually.
Warning:

.../python2.7/site-packages/skimage/transform/_warps.py:84: UserWarning: The default mode, 'constant', will be changed to 'reflect' in skimage 0.15.

Fixes #5602

Signed-off-by: Finnian Anderson <get@finnian.io>
@developius
Copy link
Contributor Author

Not sure why this test is failing, the code change shouldn't have been a breaking change.

@Noiredd
Copy link
Member

Noiredd commented Nov 2, 2017

I have restarted the tests that failed prior to #5973, it passes now.

Indeed, skimage.transform.resize used to have a default argument mode='constant' which will change to None in future versions. Thank you for the fix!

@Noiredd Noiredd merged commit d8b4283 into BVLC:master Nov 2, 2017
@developius developius deleted the fix-default-mode-warning branch November 2, 2017 13:20
@alexellis
Copy link

Nice one @developius 👍 Caffe is awesome..

XinYao1994 pushed a commit to XinYao1994/caffe that referenced this pull request Aug 29, 2018
Fix default mode warning in io.resize_image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

warning on resize_image from pycaffe with new version of skimage

3 participants