Skip to content

Comments

Patch c make gflags glog#5832

Open
alexyangfox wants to merge 1 commit intoBVLC:masterfrom
alexyangfox:patch-CMake-gflags-glog
Open

Patch c make gflags glog#5832
alexyangfox wants to merge 1 commit intoBVLC:masterfrom
alexyangfox:patch-CMake-gflags-glog

Conversation

@alexyangfox
Copy link

Without the quotes, the "-fPIC" flag may not be correctly passed to g++.
This will lead to "Linkage Error".

Quotes matter.

@Noiredd
Copy link
Member

Noiredd commented Nov 2, 2017

I have restarted the tests that failed prior to #5973, it passes now. Could you also squash your commits?

@ToniRV
Copy link

ToniRV commented Jan 8, 2018

👍

@alexyangfox alexyangfox force-pushed the patch-CMake-gflags-glog branch from 83e5627 to 75a75e1 Compare January 12, 2018 02:49
@alexyangfox
Copy link
Author

@Noiredd sorry, haven't been on github for a few months...
I have squashed the commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants