Fix Hyperlink not working in a Bulleted List #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 26, 2022 11:16
pragadeeshk
added a commit
that referenced
this pull request
Sep 13, 2022
* Fixed visualizer build issue for android (#90) Co-authored-by: “dan-arvi” <“daniel.arvind@bigthinkcode.com”> * Fix Hyperlink not working in a Bulleted List (#101) * bulleted text hyperlink fix * onpress Co-authored-by: Mohd Zaid <zanaseem@microsoft.com> * React native version update to 0.68.2 (#93) * Fixed visualizer build issue for android * react native version updated to 0.68.2 * Version updated for Picker&datetimePicker Co-authored-by: “dan-arvi” <“daniel.arvind@bigthinkcode.com”> * Version bump Co-authored-by: dan-arvi <106525930+dan-arvi@users.noreply.github.com> Co-authored-by: “dan-arvi” <“daniel.arvind@bigthinkcode.com”> Co-authored-by: Zaid Naseem <72800429+Zaidos9@users.noreply.github.com> Co-authored-by: Mohd Zaid <zanaseem@microsoft.com>
pragadeeshk
added a commit
that referenced
this pull request
Sep 27, 2022
* Set text as accessibility label when altText is not provided * Added accessibility focus for image component * Fixed visualizer build issue for android (#90) Co-authored-by: “dan-arvi” <“daniel.arvind@bigthinkcode.com”> * Fix Hyperlink not working in a Bulleted List (#101) * bulleted text hyperlink fix * onpress Co-authored-by: Mohd Zaid <zanaseem@microsoft.com> * React native version update to 0.68.2 (#93) * Fixed visualizer build issue for android * react native version updated to 0.68.2 * Version updated for Picker&datetimePicker Co-authored-by: “dan-arvi” <“daniel.arvind@bigthinkcode.com”> * Version bump * Fixed alignment issue due to accessibility fix Co-authored-by: dan-arvi <106525930+dan-arvi@users.noreply.github.com> Co-authored-by: “dan-arvi” <“daniel.arvind@bigthinkcode.com”> Co-authored-by: Zaid Naseem <72800429+Zaidos9@users.noreply.github.com> Co-authored-by: Mohd Zaid <zanaseem@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hyperlinks are no-op when added in a Bulleted List. This PR fixes this issue and enables hyperlink clicks.
Changes include adding link for hyperlink text (this was not getting added earlier), and then applying onPress for bulleted style as well.
Sample Card
Added
bulletedHyperlink.jsonpayload for testing the scenarioHow Verified
Added videos for before and after.
Before:
BeforeBulletedText.mov
After:
AfterBulletedText1.mov