Merged
Conversation
noel-bitgo
commented
Aug 17, 2023
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
noel-bitgo
force-pushed
the
EA-1242
branch
2 times, most recently
from
072dad4 to
08eb878
Compare
Contributor
zahin-mohammad
left a comment
zahin-mohammad
left a comment
There was a problem hiding this comment.
PR is not ready for review
noel-bitgo
force-pushed
the
EA-1242
branch
9 times, most recently
from
fc7ed1e to
aaf690a
Compare
mmcshinsky-bitgo
requested changes
Aug 17, 2023
| export interface StakeArgs { | ||
| value: string; | ||
| controller?: { id: string }; | ||
| controller: { id: string }; |
Contributor
There was a problem hiding this comment.
Undocumented breaking change. Need a BREAKING CHANGE: in the commit footer.
Contributor
Author
There was a problem hiding this comment.
this is actually reverting the previous change a6f6a0d
Contributor
Author
There was a problem hiding this comment.
i'll keep that in mind for future breaking changes
Contributor
zahin-mohammad
left a comment
zahin-mohammad
left a comment
There was a problem hiding this comment.
Im lacking some context on the dot implementation, but from skimming the PR it lgtm. If you can get an approval from eth-alt or staking I'll approve this PR.
sachushaji
approved these changes
Aug 18, 2023
aarvay
approved these changes
Aug 18, 2023
alebusse
approved these changes
Aug 18, 2023
mmcshinsky-bitgo
approved these changes
Aug 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update DOT library to remove controller optional field -> paritytech/txwrapper-core#309 and paritytech/substrate#14039
DOT is defaulting the controller address as the stash address