fix!: removes controller arg from bond and setController methods#309
fix!: removes controller arg from bond and setController methods#309
bond and setController methods#309Conversation
EmilIvanichkovv
left a comment
EmilIvanichkovv
left a comment
There was a problem hiding this comment.
Today, as I was in the process of preparing a Pull Request to add the Westend metadata and registry (needed it for offline decoding of unsigned transactions in Westend), I noticed that you have already merged and released the changes. It's wonderful to see that the feature I needed was implemented on the very same day!
However, I do have one question or concern. Shouldn't the tokenDecimals value for Westend be 12 instead of 10? I have provided a review on the Pull Request and have also created a separate Pull Request to address this issue. I based my understanding on the information outlined in the following resource: https://wiki.polkadot.network/docs/learn-DOT#getting-tokens-on-the-westend-testnet.
Thank you for your attention and great work!
| return mockGetRegistryBase({ | ||
| chainProperties: { | ||
| ss58Format: 0, | ||
| tokenDecimals: 10, |
There was a problem hiding this comment.
Doesn't the value of tokenDecimals need to be 12 instead of 10?
There was a problem hiding this comment.
Totally correct, I also added a comment in the PR you added. I really appreciate the thorough check, and thank you so much!
4 participants
Description
Following the
controllerchanges in the substrate PR (related forum post), we also update the same methods intxwrapper-core:bondandsetControllerby removing the
controllerargument.Additional Metadata
Westend Metadata v9430 were added so we can test the changes in the updated methods (
bondandsetController).Tests
The expected results/hex calls in bond.spec.ts and setController.spec.ts were updated accordingly.
The new hex calls
0x0600910100for the bond test0x0608for the setController testcan be double checked in pjs-apps > Decode section (connected to Westend) where you can see that the
controllerargument is no longer present.