Skip to content

use vendored distutils.version to avoid DeprecationWarnings #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FrancescAlted merged 3 commits into from
Jul 13, 2022
Merged

use vendored distutils.version to avoid DeprecationWarnings #270

FrancescAlted merged 3 commits into from
Jul 13, 2022

Conversation

@graingert
Copy link
Contributor

@graingert graingert commented Mar 29, 2022

No description provided.

@graingert
Copy link
Contributor Author

graingert commented Mar 29, 2022

importing blosc on Python3.10 shows the following error:

python -W error
Python 3.10.4 | packaged by conda-forge | (main, Mar 24 2022, 17:38:57) [GCC 10.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import blosc
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/graingert/miniconda3/envs/dask-distributed-310/lib/python3.10/site-packages/blosc/__init__.py", line 37, in <module>
    from blosc.toplevel import (
  File "/home/graingert/miniconda3/envs/dask-distributed-310/lib/python3.10/site-packages/blosc/toplevel.py", line 11, in <module>
    from distutils.version import LooseVersion
  File "/home/graingert/miniconda3/envs/dask-distributed-310/lib/python3.10/distutils/__init__.py", line 19, in <module>
    warnings.warn(_DEPRECATION_MESSAGE,
DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives
>>>

@graingert
Copy link
Contributor Author

graingert commented Mar 29, 2022

using packaging.version is probably preferred longterm but I think on balance distutils.version.LooseVersion isn't much code to vendor and saves a 3rd party dep

FrancescAlted
FrancescAlted approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@FrancescAlted FrancescAlted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FrancescAlted FrancescAlted merged commit dcc35cb into Blosc:master Jul 13, 2022
@FrancescAlted
Copy link
Member

FrancescAlted commented Jul 13, 2022

Thanks @graingert !

@graingert graingert deleted the avoid-deprecated-distutils branch July 13, 2022 16:09
@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request Jul 13, 2022
Merged
FrancescAlted pushed a commit that referenced this pull request Jul 14, 2022
@DimitriPapadopoulos
Fix error in tests introduced by #270 (#277)
f9b77b9 
https://iq-inc.com/importerror-attempted-relative-import/
@DimitriPapadopoulos
Copy link
Contributor

DimitriPapadopoulos commented Jul 15, 2022

PEP 632 advises distutils.version is replaced by the packaging package.

graingert added a commit to graingert/python-blosc that referenced this pull request Jul 15, 2022
@graingert
Revert "Fix error in tests introduced by Blosc#270 (Blosc#277)"
15afb41 
This reverts commit f9b77b9.
@graingert graingert mentioned this pull request Jul 15, 2022
Merged
FrancescAlted pushed a commit that referenced this pull request Jul 15, 2022
@graingert
fix incorrect import of blosc._version (#278)
49dbd0c 
* Revert "Fix error in tests introduced by #270 (#277)"

This reverts commit f9b77b9.

* fix incorrect import of blosc._version

* Update .github/workflows/build.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FrancescAlted FrancescAlted FrancescAlted approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@graingert @FrancescAlted @DimitriPapadopoulos