Skip to content

Fix error in tests introduced by #270 #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FrancescAlted merged 1 commit into from
Jul 14, 2022
Merged

Fix error in tests introduced by #270 #277

FrancescAlted merged 1 commit into from
Jul 14, 2022

Conversation

@DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Jul 13, 2022 •
edited
Loading

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as draft July 13, 2022 20:27
@FrancescAlted FrancescAlted marked this pull request as ready for review July 14, 2022 09:12
@FrancescAlted
Copy link
Member

FrancescAlted commented Jul 14, 2022

LGTM

@FrancescAlted FrancescAlted merged commit f9b77b9 into Blosc:master Jul 14, 2022
@FrancescAlted
Copy link
Member

FrancescAlted commented Jul 14, 2022

Thanks @DimitriPapadopoulos !

@DimitriPapadopoulos DimitriPapadopoulos deleted the ImportError_attempted_relative_import branch July 14, 2022 09:51
graingert
graingert reviewed Jul 15, 2022
View reviewed changes
blosc/toplevel.py
import os
import sys
from ._version import LooseVersion
import _version
Copy link
Contributor

@graingert graingert Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't going to work when the package is installed

Copy link
Contributor Author

@DimitriPapadopoulos DimitriPapadopoulos Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to fix tests? It might be preferable to switch to packages as suggested by PEP 632.

Copy link
Contributor Author

@DimitriPapadopoulos DimitriPapadopoulos Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would that be OK?

from blosc._version import LooseVersion

graingert added a commit to graingert/python-blosc that referenced this pull request Jul 15, 2022
@graingert
Revert "Fix error in tests introduced by Blosc#270 (Blosc#277)"
15afb41 
This reverts commit f9b77b9.
@graingert graingert mentioned this pull request Jul 15, 2022
Merged
FrancescAlted pushed a commit that referenced this pull request Jul 15, 2022
@graingert
fix incorrect import of blosc._version (#278)
49dbd0c 
* Revert "Fix error in tests introduced by #270 (#277)"

This reverts commit f9b77b9.

* fix incorrect import of blosc._version

* Update .github/workflows/build.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@graingert graingert graingert left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DimitriPapadopoulos @FrancescAlted @graingert