Skip to content

[BI-1825] add check for legacy trait names in ExperimentProcessor#267

Closed
dmeidlin wants to merge 1 commit intodevelopfrom
bug/BI-1825
Closed

[BI-1825] add check for legacy trait names in ExperimentProcessor#267
dmeidlin wants to merge 1 commit intodevelopfrom
bug/BI-1825

Conversation

@dmeidlin
Copy link
Contributor

@dmeidlin dmeidlin commented Jun 21, 2023

Description

Story: BI-1825

Update dExperimentProcessor::addObsVarsToDatasetDetails (GitHub link) to check if the Trait.fullName field is populated, and if so, then append the program key, otherwise don’t.

Dependencies

testing needs to be done with a program connected to a brapi service using legacy trait names

Testing

To test, upload an experiment with phenotypic data that uses Traits that are defined in BreedBase without program key namespacing.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@github-actions github-actions bot added the bug Something isn't working label Jun 21, 2023
@dmeidlin dmeidlin marked this pull request as ready for review June 22, 2023 18:10
@dmeidlin dmeidlin requested review from a team, nickpalladino and timparsons and removed request for a team June 22, 2023 18:10
@timparsons timparsons changed the base branch from develop to release/0.8 July 6, 2023 02:26
@timparsons timparsons changed the base branch from release/0.8 to develop July 6, 2023 02:27
@timparsons
Copy link
Member

Targeting the wrong branch, and switching target branches will bring forward v0.8.1 changes into v0.8. Created a new branch and PR: #270

@timparsons timparsons closed this Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants