Upgrade commons-pool 1.x to commons-pool2 2.12.0#2
Open
devin-ai-integration[bot] wants to merge 1 commit intodevelop-7.0.xfrom
Open
Upgrade commons-pool 1.x to commons-pool2 2.12.0#2devin-ai-integration[bot] wants to merge 1 commit intodevelop-7.0.xfrom
devin-ai-integration[bot] wants to merge 1 commit intodevelop-7.0.xfrom
Conversation
- Replace commons-pool:commons-pool:1.6 with org.apache.commons:commons-pool2:2.12.0 in root pom.xml dependency management - Update dependency reference in admin/broadleaf-open-admin-platform/pom.xml - Migrate GenericObjectPool import from org.apache.commons.pool.impl to org.apache.commons.pool2.impl in SandBoxConnection.java Co-Authored-By: Arjun Mishra <arjunsaxmishra@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
devin-ai-integration Bot
added a commit
that referenced
this pull request
Apr 17, 2026
…s args, add @TestMethodOrder/@order - Issue #1: Remove unused Method parameter from CustomerPhoneControllerTest.setupCustomerId() to prevent JUnit 5 ParameterResolutionException - Issue #2: Swap assertEquals argument order from TestNG convention (actual, expected) to JUnit 5 convention (expected, actual) in RollbackTest, SystemPropertiesTest, WorkflowTest - Issue #3: Add @TestMethodOrder(MethodOrderer.OrderAnnotation.class) and @order(N) annotations to 21 test classes with execution order dependencies to preserve test method ordering - Use fully qualified @org.junit.jupiter.api.Order where it conflicts with domain Order class Co-Authored-By: Arjun Mishra <arjunsaxmishra@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Replaces the end-of-life Apache Commons Pool 1.x (
commons-pool:commons-pool:1.6) with Commons Pool 2 (org.apache.commons:commons-pool2:2.12.0). Commons Pool 1.x has been unsupported since 2013 and carries known CVE exposure.Labels: Enhancement, Status: ready-for-code-review
Changes
pom.xml– Updated<dependencyManagement>entry: changed groupId, artifactId, and version fromcommons-pool:commons-pool:1.6→org.apache.commons:commons-pool2:2.12.0.admin/broadleaf-open-admin-platform/pom.xml– Updated the module-level dependency reference to match the new coordinates.SandBoxConnection.java– Migrated theGenericObjectPoolimport fromorg.apache.commons.pool.impltoorg.apache.commons.pool2.impl. No behavioral changes; thereturnObject()call onclose()is API-compatible.Verified via
mvn compileandmvn dependency:treethat:Human Review Checklist
SandBoxConnectionusesGenericObjectPoolwithout a type parameter (raw type). This compiles with an unchecked warning but is functionally correct. Consider whether it should be parameterized asGenericObjectPool<Connection>in a follow-up.GenericObjectPoolpassed intoSandBoxConnectionis also compatible with pool2 (e.g., no use of the removedGenericObjectPool.Configclass).mvn dependency:treeacross all modules.Link to Devin session: https://app.devin.ai/sessions/b3253ade478546bea3194f4267ac6c9d
Requested by: @Colhodm