Ticket 5.1: Update compiler target to Java 21#3
Open
devin-ai-integration[bot] wants to merge 1 commit intodevelop-7.0.xfrom
Open
Ticket 5.1: Update compiler target to Java 21#3devin-ai-integration[bot] wants to merge 1 commit intodevelop-7.0.xfrom
devin-ai-integration[bot] wants to merge 1 commit intodevelop-7.0.xfrom
Conversation
- Root pom.xml: update maven-compiler-plugin source/target/release from 17 to 21 - Root pom.xml: update gmavenplus-plugin targetBytecode from 17 to 21 - common/pom.xml: update maven-compiler-plugin source/target from 17 to 21 - admin/broadleaf-admin-module/pom.xml: update maven-compiler-plugin source/target from 17 to 21 All 13 modules compile successfully with JDK 21. Co-Authored-By: Arjun Mishra <arjunsaxmishra@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
devin-ai-integration Bot
added a commit
that referenced
this pull request
Apr 17, 2026
…s args, add @TestMethodOrder/@order - Issue #1: Remove unused Method parameter from CustomerPhoneControllerTest.setupCustomerId() to prevent JUnit 5 ParameterResolutionException - Issue #2: Swap assertEquals argument order from TestNG convention (actual, expected) to JUnit 5 convention (expected, actual) in RollbackTest, SystemPropertiesTest, WorkflowTest - Issue #3: Add @TestMethodOrder(MethodOrderer.OrderAnnotation.class) and @order(N) annotations to 21 test classes with execution order dependencies to preserve test method ordering - Use fully qualified @org.junit.jupiter.api.Order where it conflicts with domain Order class Co-Authored-By: Arjun Mishra <arjunsaxmishra@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Overview
Updates all Maven compiler configuration across the project to target Java 21, up from Java 17. This is a build-config-only change — no Java source code is modified (Java 21 language features are out of scope for this PR).
Changes
pom.xml: Updatedmaven-compiler-plugin<source>,<target>, and<release>from17→21; updatedgmavenplus-plugin<targetBytecode>from17→21common/pom.xml: Updated module-levelmaven-compiler-plugin<source>and<target>from17→21admin/broadleaf-admin-module/pom.xml: Updated module-levelmaven-compiler-plugin<source>and<target>from17→21All other module POMs (core, integration, admin sub-modules) inherit from the root and have no compiler overrides — verified via search.
Labels: Enhancement, Status: ready-for-code-review
Milestone: 7.0.7-SNAPSHOT
Verification
mvn compile -DskipTestspasses for all 13 modules on JDK 21.Human Review Checklist
common/pom.xmlandadmin/broadleaf-admin-module/pom.xmldo not set<release>(only<source>/<target>), matching their pre-existing pattern — consider whether adding<release>21</release>for consistency is desiredLink to Devin session: https://app.devin.ai/sessions/3dc8d8ba13094758b84bc8154ab7a1b4
Requested by: @Colhodm