Merged
Conversation
fix: update logging configuration and correct typos in environment files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to environment configurations, logging setup, and Dockerfile optimizations. The changes aim to improve security, enhance logging flexibility, and streamline the container setup. Below is a summary of the most important changes grouped by theme.
Environment Configuration Updates:
CORS_ALLOW_CREDENTIALStofalsein.env.exampleto enhance security by disallowing credentials in cross-origin requests.ROOT_LOG_LEVELandCALLV2_LOG_LEVELfrom.env.exampleto simplify log level configuration.Dockerfile Optimizations:
eclipse-temurin:21.0.7_6-jdk-alpinetoeclipse-temurin:21.0.7_6-jre-alpineto reduce image size by using the JRE instead of the JDK./var/log/drive-apiand refined ownership setup for/srv/drive/storageand/var/log/drive-api.Logging Configuration Enhancements:
log4j2-spring.xmlto use consistent and descriptive property names (e.g.,rootLogLevelConsole,logPath) and changed default file and JSON log levels toofffor better control over logging.com.callv2logger levels toallinlog4j2-spring.xmlto capture all log events by default.Bug Fixes:
application-env.ymlandapplication.ymlby changingreuqest-timeouttorequest-timeoutto ensure proper configuration parsing. [1] [2]