Conversation
* Refactor for incoming protocol upgrade * The type should be what is sent, not the sending mechanism
* support in cliain for version_upgrade * support of our docker-compose to run using bridged docker's network * catchup_version_upgrade_test.sh * added the catchup version upgrade test to github pipelines * review changes * chmod +x catchup_version_upgrade_test.sh * review changes: using `matrix` for catch-up version upgrade test * review changes: bumped version of aleph-client; added schedule_version_upgrade_with_state * review changes: comment about key derivation in docker-compose `//1` etc. * fix: e2e...yml: wrong `uses` * bumped e2e-tests/Cargo.lock * fix: version_upgrade after api refactor * review changes: added cache cleanup to build-cliain-image job * fix: typo in e2e...yml s/NODE2/Node2 * fix for e2e...yml: fixed matrix-include for catch-up version upgrade test * review changes: renamed local variable in catchup_version_upgrade.sh * more review changes for catchup_version_upgrade_test.sh
* Checkpoint * Partial attempt * Fixed index * Touch up * Reworked automatic test for greater modularity * Partial manual kick-out * Modularity; bumped crate versions * GH workflow * Test case reordering * Initial modules work * Manual kickout case * Consts * Modules * Checkpoint * Removed next era validators check * Checkpoint * Semver consistent versioning * Removed superfluous function and imports * Checkpoint * Explicit params for bounded vec * Merge fixes * Changed bounded vec creation * Linter, version * Fixed reason passed to extrinsic * Session count tracking * Welcome to the ban world! * GH workflow * Changed params to refs; cases reorder * Housekeeping * Version bumps * Changed option unwrapping * Removed needless borrow * Added ban event call * Removed borrows * Removed ban event call from initial place * Changed test logic to post factum * Changed logic to test only sessions after ban config change comes in * Test logic fix * Typo fix in rewards test * Removed unnecessary reference * Rolled back pallet change * aleph-client version bump
…ction (#716) * Add future protocol and decision process for connection direction Not used for now, that'll be in the next PR. * Small review comments * Massively improve xor computation * Naming in tests
* remove legacy network * fix tests * remove unnecessary comment * fix test names
* Enable two-way connections * Add comments, remove typos * Clarify legacy marking logic * Linter
…726) * Remove substrate NetworkIdentity * No Multiaddress requirement for substrate network * Remove unnecessary wrappers
* At most one discovery message * Clippy being helpful
* Remove unnecessary abstraction layers in network * Test name made little sense now
* fix runtime * fix aleph-node * bump spec version * bump versions * update runtime in aleph-client * Temporarily remove try-runtime * review nits * fix tests * reintroduce try-runtime * whitespaces Co-authored-by: Jan Koscisz <koscis.j@gmail.com> Co-authored-by: kostekIV <27210860+kostekIV@users.noreply.github.com>
* Replace AuthorityId with parameter * SecretKey is a much better name than PrivateKey * Rename most peer ids to public keys Co-authored-by: lesniak43 <lesniak43@gmail.com>
* add backend * request justification from forks * change requesting logic * Request penultimate block * review changes * fix rename leftover * simplify backend dependecy * Rework justification request status * Revert "simplify backend dependecy" This reverts commit abf2605. * fix revert * fix service * warn about missing blocks * improve comment * Review changes * improve comment * split and simplify request logic * Do do_request wanted * Clearer? * fix inequality after moving surrounding block * Always count child tries * impl BB * prepare for tests * Fix tests * bump version * fmt * Simplify backend trait * fmt * Missing generic
* Unify MockMultiaddress * Random multiaddress function * Some clippy warnings
* docker related configs for network-delay tests * shell script for simple network-delay test * - renamed dockerfile for network tests - chmod +x for network_tests scripts * added common.sh for scripts; more user friendly run_consensus_network_delay.sh * refactored run_consensus_network_delay.sh * checking relative-finalization
* Limit nonfinalized block production * Better saturation handling * Add log when delaying block production * Disable two tests that were operating under outdated assumptions * Disable one more test
* Remove validators from candidates in elections when they're got benned * Add missing config item * bump spec version * Adjust mock * Don't ban nice guys * fmt * typo Co-authored-by: Marcin <marcin.radecki@cardinals.cc>
* Use the default rust test runner * Update CI flow to use the new runner * Refer to finalization test unambiguously in CI * Remove accidentally commited .idea * Fix mismerge * Refer explicitly to some more testcases * Refer explicitly to some more testcases * Initialize logging in e2e tests * Ignore ban_automatic test for now See https://cardinal-cryptography.atlassian.net/browse/A0-1634 * Rename config() -> setup_test() * Take e2e test binary location from cargo * Update e2e docker build in nightly * Fix typo
* Added pending_rewards call to nomination pool api to our runtime * Set runtime version to 0.8.4
* add experimental_pruning flag * add default value * fmt Co-authored-by: Jedrzej Kula <jedrzej.kula@cardinals.cc>
#790) * Make connection manager operate of validator network directly * Fix and simplify network service tests
* enforce-heap-pages * set call stack * bump-spec-version * fix-typo --------- Co-authored-by: Michal Swietek <mike1729@users.noreply.github.com>
* change fork version to 0.9.34 * pallet contracts UnsafeUnstableInterface set to false * subxt code gen * temporarily remove fee calculation test * fix build * change fork version to aleph-0.9.34 * bump spec version to 52 * move comment up * change fork version to wip-0.9.35 * fix pruning arguments * fix weight changes * update jsonspree * fix compiler error * rm wip * lock * spec * aleph * lint * lint * cleanup * maximize build space * lint * clean before unit * revert * set tmp dir * fp * fp2 * one more try --------- Co-authored-by: KostekIV <koscis.j@gmail.com> Co-authored-by: kostekIV <27210860+kostekIV@users.noreply.github.com>
* change fork version to 0.9.34 * pallet contracts UnsafeUnstableInterface set to false * subxt code gen * temporarily remove fee calculation test * fix build * change fork version to aleph-0.9.34 * bump spec version to 52 * move comment up * change fork version to wip-0.9.35 * fix pruning arguments * fix weight changes * update jsonspree * fix compiler error * rm wip * lock * spec * aleph * lint * lint * cleanup * update * bump spec * set contracts-transcode version * locks * fix try-runtime --------- Co-authored-by: maciejnems <macieknems@gmail.com>
* Check contstraints for memory parameters * Add comments * Move smallvec to dev-dependencies * fmt --------- Co-authored-by: Michal Swietek <mike1729@users.noreply.github.com>
* change fork version to 0.9.34 * pallet contracts UnsafeUnstableInterface set to false * subxt code gen * temporarily remove fee calculation test * fix build * change fork version to aleph-0.9.34 * bump spec version to 52 * move comment up * change fork version to wip-0.9.35 * fix pruning arguments * fix weight changes * update jsonspree * fix compiler error * rm wip * lock * spec * aleph * lint * lint * cleanup * update * bump spec * set contracts-transcode version * locks * fix try-runtime * bump substrate * adjust runtime * fix node * update aleph-client * update adder toolchain * fix tests * dont panic * revert toolchain * nightly * skip adder * ... --------- Co-authored-by: maciejnems <macieknems@gmail.com>
* update to 0.9.38 * bump spec & lint * update metadata * set forck branch
Co-authored-by: Marcin <marcin.radecki@cardinals.cc>
Co-authored-by: Marcin <marcin.radecki@cardinals.cc>
* Empty commit to trigger actions * Add a new line to the workflow to trigger * Change most workflows to use self-hosted runners * Comment out starting sccache server as it should be started in the runner already * Add empty step to post-cache as it cannot be empty * Add missing 'shell: bash' line * Uncomment installing cargo-cache * Comment out cargo-cache * Remove restore- and post-cache from workflows * Fixed wrong merge * Use docker cargo contract image in adder e2e test * Pinned version of ink-dev. Fixed bug so non-interactive mode is used * Trying to fix added e2e * Run adder e2e test to speed up build * Run adder e2e test to speed up build - attempt 2 * Add cargo-cache with storing .cargo in S3 bucket for testing * Fix missing 'env.' in call to env vars * Add 'true' to ignore exit code != 0 * Add set +e to ignore exit code * Add caching 'target' dir and rename things a bit * Change uploading cache to devnet CI S3 bucket * Tweak step names * Comment out blocks uploading builds to S3 bucket * Do not gzip files * Extract cache key to a separate env var * Remove cache steps * Comment out using sccache * Restore sccache in build-node-and-runtime.yml * Attempt to show output from a failed test * In test catch_up, remvoe one non-validator from the test to decrease test CPU load * Switch test_catch_up to self_hosted. Changed timeout for waiting for authorities to 300s * Set CARGO_HOME to /Users/nicholas/Repositories/github.com/cc/aleph-node * Fix typo * Increased timeout for waiting for authorities in cathc_up tests * Fix typos * Add step that cleans the workspace * Change cleanup workspace step to just 'rm' commands * Extract workspace cleanup to a separate action * Remove cleanup steps * Set timeout for waiting for authorities in catch_up tests and multiple restarts to 60s * Increase multiple_restart waiting for authorities timeout to 120s --------- Co-authored-by: Marcin <marcin.radecki@cardinals.cc>
…y specifying when should the workflows be triggered (#962) * All yaml files now conformant to yamllinter * yamllinter check now checks all files * Removed not-needed protoc action from build clian workflow. Collapsed some lines which are risky to refactor. * Remove commented out line. Collapsed some lines which are risky to refactor. * fixes * Added paths/paths-ignore to workflows * Quoted paths in build-docs * Quoted paths in build-cliain * Fixed trigger in build-docs * Now quoting paths with wildcards * Review * Remove post cache action
deuszx
reviewed
Mar 7, 2023
|
|
||
| - name: Install binaryen | ||
| shell: bash | ||
| # yamllint disable rule:line-length |
Collaborator
There was a problem hiding this comment.
Do we need the binaryen (and cargo contract below) if we're using dockerized cargo contract in contracts/scripts/deploy.sh?
Contributor
Author
There was a problem hiding this comment.
Honestly, I tried to not touch this file as much as possible, I don't really know how to test the changes. Perhaps @fbielejec could check the deployments again after all this is merged.
Contributor
There was a problem hiding this comment.
I would definitely not touch any workflow files before it's all unified
fbielejec
approved these changes
Mar 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully, this is the last big thing we need to merge in from main and we can merge into main afterwards.