[ENG-10377] Prevent 403 from metadata URLs from navigating users away#896
Merged
adlius merged 1 commit intoCenterForOpenScience:hotfix/26.3.1from Feb 25, 2026
Merged
Conversation
futa-ikeda
commented
Feb 25, 2026
| if (error.status === 403) { | ||
| const requestAccessRegex = /\/v2\/nodes\/[^/]+\/requests\/?$/i; | ||
| if (error.url && requestAccessRegex.test(error.url)) { | ||
| const metadataRegex = /\/metadata\/[^/]+\/?$/i; |
Contributor
Author
There was a problem hiding this comment.
This regex feels a little fragile/hamfisted...
Contributor
Author
There was a problem hiding this comment.
Updated to use some custom request header instead
futa-ikeda
force-pushed
the
hotfix/vol-redirect
branch
from
6b9181f to
8bc53fa
Compare
futa-ikeda
changed the title
brianjgeiger
previously approved these changes
Feb 25, 2026
futa-ikeda
dismissed
brianjgeiger’s stale review
The base branch was changed.
adlius
merged commit 2ea743a
into
CenterForOpenScience:hotfix/26.3.1
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
/metadata/:idrequests navigating users awaySummary of Changes
Add new regex to error interceptorScreenshot(s)
Side Effects
QA Notes