Skip to content

[ENG-8926] fix: file dataset metadata download#11296

Merged
adlius merged 1 commit intoCenterForOpenScience:feature/pbs-25-16from
aaxelb:fix/file-metadata-500
Sep 12, 2025
Merged

[ENG-8926] fix: file dataset metadata download#11296
adlius merged 1 commit intoCenterForOpenScience:feature/pbs-25-16from
aaxelb:fix/file-metadata-500

Conversation

@aaxelb
Copy link
Contributor

@aaxelb aaxelb commented Sep 12, 2025

Purpose

fix 500 error at osf.example/metadata/<file-guid>?format=google-dataset-json-ld

Changes

  • add foaf:givenName and foaf:familyName to metadata properties automatically gathered for osf users in osf.metadata.osf_gathering
  • update GoogleDatasetJsonLdSerializer to use gathered metadata instead of assuming a database model with .contributors (partly revert af28216 )
  • update osf_tests.metadata.test_serialized_metadata (and associated fixtures) to include google-dataset-json-ld (replacing minimal osf_tests.metadata.test_google_datasets)

QA Notes

Please make verification statements inspired by your code and what your code touches.

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

ENG-8926

@aaxelb aaxelb force-pushed the fix/file-metadata-500 branch 3 times, most recently from 4816b8c to 5387d89 Compare September 12, 2025 16:29
@aaxelb aaxelb marked this pull request as ready for review September 12, 2025 16:54
@aaxelb aaxelb changed the base branch from develop to feature/pbs-25-16 September 12, 2025 16:56
@aaxelb aaxelb force-pushed the fix/file-metadata-500 branch from 5387d89 to 89854ba Compare September 12, 2025 16:57
@aaxelb aaxelb requested a review from adlius September 12, 2025 16:57
@adlius adlius merged commit 1272b0e into CenterForOpenScience:feature/pbs-25-16 Sep 12, 2025
6 checks passed
adlius added a commit that referenced this pull request Sep 17, 2025
* [ENG-8514] Remove CSRF protection from reset password api v2 POST (#11246)

* remove csrf protection from reset password endpoint

* update test

* add background color prop to Brand (#11254)

* fix flaky test_serialized_metadata

* fix throttle test

* reset throttle cache

* don't ignore components when create a view-only link

* fixed updating subscribe_osf_general_email subscription

* [ENG-7277] Update doc to include version as relationship (#11262)

* added tests

* [ENG-8691] Wrong server on reset password email (#11271)

* use same logic for admin and web password reset

* fix tests

* enable filtering for linked-nodes endpoint (#11273)

* remove deleted users from institutional dashboard (#11261)

* fixed tests

* [ENG-7803] Update text on VOL modal for registration (#11279)

* added description filtering for preprints (#11294)

## Purpose

User should be able to filter preprints by their description

## Changes

Added description to filterable fields, added tests

## Ticket

https://openscience.atlassian.net/browse/ENG-8921?atlOrigin=eyJpIjoiNmY1MDUwZjI0Mjg2NDc2OGI2N2U1ZDQ0MjIwNzU0OTAiLCJwIjoiaiJ9

* [ENG-8689] - Fix/eng 8689 (#11267)

* Fix color picker for brands

* Remove unnecessary exclusion

* fix: file dataset metadata download (#11296)

* fix linting

* merge migrations

* [ENG-8958] missing metadata (dcterms:type and osf:hasOsfAddon) (#11309)

* fix: validate resource_type_general in api

* fix: update search after updating addons

* fix: file dataset metadata with mononym creators (#11297)

* Revert "fix: file dataset metadata with mononym creators (#11297)" (#11311)

This reverts commit 21090b2.

---------

Co-authored-by: antkryt <ant.krytskyi@gmail.com>
Co-authored-by: John Tordoff <Johnetordoff@users.noreply.github.com>
Co-authored-by: Ihor Sokhan <isokhan@exoft.net>
Co-authored-by: Vlad0n20 <137097005+Vlad0n20@users.noreply.github.com>
Co-authored-by: abram axel booth <aaxelb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants