[ENG-8958] missing metadata (dcterms:type and osf:hasOsfAddon)#11309
Merged
adlius merged 2 commits intoCenterForOpenScience:feature/pbs-25-16from Sep 16, 2025
Merged
Conversation
aaxelb
force-pushed
the
fix/8958-validate-resourceTypeGeneral
branch
from
ccaae86 to
09e6696
Compare
adlius
approved these changes
Sep 16, 2025
adlius
merged commit 7a90a68
into
CenterForOpenScience:feature/pbs-25-16
13 of 14 checks passed
adlius
added a commit
that referenced
this pull request
Sep 17, 2025
* [ENG-8514] Remove CSRF protection from reset password api v2 POST (#11246) * remove csrf protection from reset password endpoint * update test * add background color prop to Brand (#11254) * fix flaky test_serialized_metadata * fix throttle test * reset throttle cache * don't ignore components when create a view-only link * fixed updating subscribe_osf_general_email subscription * [ENG-7277] Update doc to include version as relationship (#11262) * added tests * [ENG-8691] Wrong server on reset password email (#11271) * use same logic for admin and web password reset * fix tests * enable filtering for linked-nodes endpoint (#11273) * remove deleted users from institutional dashboard (#11261) * fixed tests * [ENG-7803] Update text on VOL modal for registration (#11279) * added description filtering for preprints (#11294) ## Purpose User should be able to filter preprints by their description ## Changes Added description to filterable fields, added tests ## Ticket https://openscience.atlassian.net/browse/ENG-8921?atlOrigin=eyJpIjoiNmY1MDUwZjI0Mjg2NDc2OGI2N2U1ZDQ0MjIwNzU0OTAiLCJwIjoiaiJ9 * [ENG-8689] - Fix/eng 8689 (#11267) * Fix color picker for brands * Remove unnecessary exclusion * fix: file dataset metadata download (#11296) * fix linting * merge migrations * [ENG-8958] missing metadata (dcterms:type and osf:hasOsfAddon) (#11309) * fix: validate resource_type_general in api * fix: update search after updating addons * fix: file dataset metadata with mononym creators (#11297) * Revert "fix: file dataset metadata with mononym creators (#11297)" (#11311) This reverts commit 21090b2. --------- Co-authored-by: antkryt <ant.krytskyi@gmail.com> Co-authored-by: John Tordoff <Johnetordoff@users.noreply.github.com> Co-authored-by: Ihor Sokhan <isokhan@exoft.net> Co-authored-by: Vlad0n20 <137097005+Vlad0n20@users.noreply.github.com> Co-authored-by: abram axel booth <aaxelb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
metadata missing from search (and institutional dashboard) --
resourceNature(dcterms:type, used for datacite'sresourceTypeGeneral) andosf:hasOsfAddonshould be there, but aren'tChanges
resource_type_generalto aChoiceFieldto prevent invalid values from frontendDATACITE_RESOURCE_TYPES_GENERALcontrolled vocab to a more sensible place for reuselog_gv_addontask (run after addons changed) to callnode.update_search()for public nodesQA Notes
Please make verification statements inspired by your code and what your code touches.
resourceTypeGeneralin datacite xmlosf.example/metadata/<osfid>/?format=datacite-xmlhasOsfAddonproperty atstaging-share.osf.io/trove/index-card-search?acceptMediatype=application%2Fvnd.api%2Bjson&cardSearchText[identifier]=<osfid>Ticket
ENG-8958