[ENG-3866] Move citation style population out of migration stream by Johnetordoff · Pull Request #9966 · CenterForOpenScience/osf.io

Johnetordoff · 2022-06-27T13:23:46Z

Purpose

Pulls citations sytles out of migration stream and makes updating styles a management command.

Changes

pulls citation styles population out of the migration stream
makes management command to update citation styles.
- load ziip file from github repo via requests
- minor logical improvements for python3
- made single tranaction with dry_run rollback

QA Notes

Please make verification statements inspired by your code and what your code touches.

Verify
Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

https://openscience.atlassian.net/browse/ENG-3866

cslzchen

Pass one complete!

cslzchen

👍 for the detailed clarification. PR looks great with minor coding / style nit-pick. 2nd pass done 🎆

jwalz

Undelete the test fixture if skipin tests instead of removing

cslzchen

PR looks great! RTM ⭐

cslzchen

Performed a rebase and fixed conflicts for each commit. Will merge after Github Action is happy.

Johnetordoff · 2022-07-15T18:26:30Z


    @pytest.fixture()
    def registration_provider(self, open_ended_schema, provider_subjects):
-        osf_provider = RegistrationProvider.get_default()


Why did you do this? the _id should not be hard coded.

Good question! I reverted this back to the same as the feature branch since I thought this meant to be in the scope of your provider PR. During my commit-by-commit rebase, this one has been changed several times so I went with the safe way. But I should've mentioned this on my review for transparency.

…OpenScience/osf.io into upguard-indexes * 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: [ENG-3866] Move citation style population out of migration stream (CenterForOpenScience#9966) # Conflicts: # api/base/settings/defaults.py # osf/management/commands/sync_citation_styles.py # osf/migrations/0074_parse_citation_styles.py # osf/migrations/0107_add_dependent_styles.py # osf_tests/test_registration_bulk_upload_parser.py # tests/test_citeprocpy.py

…OpenScience/osf.io into signal-storage-region * 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: [ENG-3866] Move citation style population out of migration stream (CenterForOpenScience#9966) [ENG-3868] Move blocked email domains to post-migrate signal (CenterForOpenScience#9958) [ENG-3863] Move schema ensuring and schema blocks update to post-migrate signals (CenterForOpenScience#9974) Instrument the ORCiD SSO affiliation flow * Existing user with verified ORCiD ID * Existing user confirmation of linking ORCiD ID * New user confirmation of account creation with ORCiD ID Add a django command script to handle instn sso email domain changes Bump version and CHANGELOG # Conflicts: # osf/apps.py # osf/migrations/__init__.py

…OpenScience/osf.io into signal-create-providers-2 * 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: [ENG-3866] Move citation style population out of migration stream (CenterForOpenScience#9966) [ENG-3868] Move blocked email domains to post-migrate signal (CenterForOpenScience#9958) [ENG-3863] Move schema ensuring and schema blocks update to post-migrate signals (CenterForOpenScience#9974) [ENG-3865] Create Licenses using post-migrate signal (CenterForOpenScience#9961) Instrument the ORCiD SSO affiliation flow * Existing user with verified ORCiD ID * Existing user confirmation of linking ORCiD ID * New user confirmation of account creation with ORCiD ID Add a django command script to handle instn sso email domain changes Bump version and CHANGELOG # Conflicts: # osf/apps.py # osf/migrations/__init__.py # osf_tests/test_registration_bulk_upload_parser.py

…nterForOpenScience#9966) * Move loading of citation styles to post-migration signal * Peg repo to commit SHA * Attempt to speed things up by loading fixture * Move update_citation_styles to management command * Remove old test like thing * Clean up URL setting and docstring * Remove install bower from CI setup * Reorder imports * Reintroduce tests, but test skip them * Final clean-up Co-authored-by: John Tordoff <> Co-authored-by: Longze Chen <cslzchen@gmail.com>

) * Move loading of citation styles to post-migration signal * Peg repo to commit SHA * Attempt to speed things up by loading fixture * Move update_citation_styles to management command * Remove old test like thing * Clean up URL setting and docstring * Remove install bower from CI setup * Reorder imports * Reintroduce tests, but test skip them * Final clean-up Co-authored-by: John Tordoff <> Co-authored-by: Longze Chen <cslzchen@gmail.com>

…OpenScience/osf.io into upguard-indexes * 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: [ENG-3867] Create Storage Regions on post migration signal (CenterForOpenScience#9965) [ENG-3866] Move citation style population out of migration stream (CenterForOpenScience#9966) [ENG-3868] Move blocked email domains to post-migrate signal (CenterForOpenScience#9958) [ENG-3863] Move schema ensuring and schema blocks update to post-migrate signals (CenterForOpenScience#9974) [ENG-3865] Create Licenses using post-migrate signal (CenterForOpenScience#9961) [ENG-3836] Investigate waffle flags (CenterForOpenScience#9950) move createcachetable to post migrate signal (CenterForOpenScience#9944) remove post-migrate signals from migration stream (CenterForOpenScience#9964) [ENG-3898][ENG-3899]Model support for OutcomeArtifact update and delete (CenterForOpenScience#9989) Make OutcomeArtifact.identifier nullable (CenterForOpenScience#9986) [ENG-3894] Outcome models (CenterForOpenScience#9975) revert color picker to working version (CenterForOpenScience#9968) # Conflicts: # api/base/settings/defaults.py # osf/migrations/0037_ensure_licenses.py # osf/migrations/0038_ensure_schemas.py # osf/migrations/0074_parse_citation_styles.py # osf/migrations/0077_ensure_schemas.py # osf/migrations/0078_ensure_schemas.py # osf/migrations/0080_ensure_schemas.py # osf/migrations/0083_add_ember_waffle_flags.py # osf/migrations/0095_add_url_to_licenses.py # osf/migrations/0095_ensure_licenses.py # osf/migrations/0096_ensure_schemas.py # osf/migrations/0099_add_default_storage_region.py # osf/migrations/0107_add_dependent_styles.py # osf/migrations/0112_ensure_schemas.py # osf/migrations/0121_remove_support_page_waffle_flag.py # osf/migrations/0121_remove_waffle_flags.py # osf/migrations/0135_user_settings_waffles.py # osf/migrations/0136_add_ember_auth_register_waffle_flag.py # osf/migrations/0136_preprint_node_divorce.py # osf/migrations/0137_transfer_preprint_service_permissions.py # osf/migrations/0138_ensure_subjects_and_providers.py # osf/migrations/0142_change_registration_schemas.py # osf/migrations/0142_remove_forks_flag.py # osf/migrations/0142_remove_waffle_analytics_flags.py # osf/migrations/0144_add_prereg_winddown_switches.py # osf/migrations/0147_blacklistedemaildomain.py # osf/migrations/0149_add_datacite_doi_switch.py # osf/migrations/0152_ensure_schemas.py # osf/migrations/0154_remove_ember_project_registrations_flag.py # osf/migrations/0156_create_cache_table.py # osf/migrations/0157_add_storage_usage_flag.py # osf/migrations/0162_post_migrate.py # osf/migrations/0167_auto_20190506_1556.py # osf/migrations/0170_ensure_schemas.py # osf/migrations/0172_ensure_schemas.py # osf/migrations/0173_ensure_schemas.py # osf/migrations/0174_add_ab_testing_home_page_version_b_flag.py # osf/migrations/0191_migrate_schemas_to_schemablocks.py # osf/migrations/0195_add_enable_chronos_waffle_flag.py # osf/migrations/0196_update_schemas.py # osf/migrations/0197_add_ab_testing_home_page_hero_text_version_b_flag.py # osf/migrations/0199_draft_node_permissions.py # osf/migrations/0201_add_egap_flag.py # osf/migrations/0204_ensure_schemas.py # osf/migrations/0207_ensure_schemas.py # osf/migrations/0207_update_schemas2.py # osf/migrations/0208_update_EGAP_schema.py # osf/migrations/0221_add_schemas.py # osf/migrations/0227_add_secondary_data.py # osf/migrations/__init__.py # osf_tests/test_registration_bulk_upload_parser.py

…OpenScience/osf.io into signal-create-providers-2 * 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: [ENG-3836] Follow-up: Add PyYAML to Requirements (CenterForOpenScience#9993) [ENG-3867] Create Storage Regions on post migration signal (CenterForOpenScience#9965) [ENG-3866] Move citation style population out of migration stream (CenterForOpenScience#9966) [ENG-3868] Move blocked email domains to post-migrate signal (CenterForOpenScience#9958) [ENG-3863] Move schema ensuring and schema blocks update to post-migrate signals (CenterForOpenScience#9974) [ENG-3865] Create Licenses using post-migrate signal (CenterForOpenScience#9961) [ENG-3836] Investigate waffle flags (CenterForOpenScience#9950) move createcachetable to post migrate signal (CenterForOpenScience#9944) remove post-migrate signals from migration stream (CenterForOpenScience#9964) [ENG-3898][ENG-3899]Model support for OutcomeArtifact update and delete (CenterForOpenScience#9989) Make OutcomeArtifact.identifier nullable (CenterForOpenScience#9986) [ENG-3894] Outcome models (CenterForOpenScience#9975) revert color picker to working version (CenterForOpenScience#9968) # Conflicts: # osf/apps.py # osf/migrations/__init__.py # osf_tests/test_registration_bulk_upload_parser.py

…OpenScience/osf.io into upgrade-import-paths * 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: [ENG-3836] Follow-up: Add PyYAML to Requirements (CenterForOpenScience#9993) [ENG-3867] Create Storage Regions on post migration signal (CenterForOpenScience#9965) [ENG-3866] Move citation style population out of migration stream (CenterForOpenScience#9966) [ENG-3868] Move blocked email domains to post-migrate signal (CenterForOpenScience#9958) [ENG-3863] Move schema ensuring and schema blocks update to post-migrate signals (CenterForOpenScience#9974) [ENG-3865] Create Licenses using post-migrate signal (CenterForOpenScience#9961) [ENG-3836] Investigate waffle flags (CenterForOpenScience#9950) move createcachetable to post migrate signal (CenterForOpenScience#9944) remove post-migrate signals from migration stream (CenterForOpenScience#9964) [ENG-3898][ENG-3899]Model support for OutcomeArtifact update and delete (CenterForOpenScience#9989) Make OutcomeArtifact.identifier nullable (CenterForOpenScience#9986) [ENG-3894] Outcome models (CenterForOpenScience#9975) revert color picker to working version (CenterForOpenScience#9968)

…OpenScience/osf.io into upgrade-markdown * 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: [ENG-3836] Follow-up: Add PyYAML to Requirements (CenterForOpenScience#9993) [ENG-3867] Create Storage Regions on post migration signal (CenterForOpenScience#9965) [ENG-3866] Move citation style population out of migration stream (CenterForOpenScience#9966) [ENG-3868] Move blocked email domains to post-migrate signal (CenterForOpenScience#9958) [ENG-3863] Move schema ensuring and schema blocks update to post-migrate signals (CenterForOpenScience#9974) [ENG-3865] Create Licenses using post-migrate signal (CenterForOpenScience#9961) [ENG-3836] Investigate waffle flags (CenterForOpenScience#9950) move createcachetable to post migrate signal (CenterForOpenScience#9944) remove post-migrate signals from migration stream (CenterForOpenScience#9964) [ENG-3898][ENG-3899]Model support for OutcomeArtifact update and delete (CenterForOpenScience#9989) Make OutcomeArtifact.identifier nullable (CenterForOpenScience#9986) [ENG-3894] Outcome models (CenterForOpenScience#9975) revert color picker to working version (CenterForOpenScience#9968)

…OpenScience/osf.io into upgrade-password-reset * 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: [ENG-3836] Follow-up: Add PyYAML to Requirements (CenterForOpenScience#9993) [ENG-3867] Create Storage Regions on post migration signal (CenterForOpenScience#9965) [ENG-3866] Move citation style population out of migration stream (CenterForOpenScience#9966) [ENG-3868] Move blocked email domains to post-migrate signal (CenterForOpenScience#9958) [ENG-3863] Move schema ensuring and schema blocks update to post-migrate signals (CenterForOpenScience#9974) [ENG-3865] Create Licenses using post-migrate signal (CenterForOpenScience#9961) [ENG-3836] Investigate waffle flags (CenterForOpenScience#9950) move createcachetable to post migrate signal (CenterForOpenScience#9944) remove post-migrate signals from migration stream (CenterForOpenScience#9964) [ENG-3898][ENG-3899]Model support for OutcomeArtifact update and delete (CenterForOpenScience#9989) Make OutcomeArtifact.identifier nullable (CenterForOpenScience#9986) [ENG-3894] Outcome models (CenterForOpenScience#9975) revert color picker to working version (CenterForOpenScience#9968)

…OpenScience/osf.io into django-3-with-django-include * 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: [ENG-3862] Move post-migrate signal out of migration stream for default providers (CenterForOpenScience#9971) [ENG-3836] Follow-up: Add PyYAML to Requirements (CenterForOpenScience#9993) [ENG-3867] Create Storage Regions on post migration signal (CenterForOpenScience#9965) [ENG-3866] Move citation style population out of migration stream (CenterForOpenScience#9966) [ENG-3868] Move blocked email domains to post-migrate signal (CenterForOpenScience#9958) [ENG-3863] Move schema ensuring and schema blocks update to post-migrate signals (CenterForOpenScience#9974) [ENG-3865] Create Licenses using post-migrate signal (CenterForOpenScience#9961) [ENG-3836] Investigate waffle flags (CenterForOpenScience#9950) move createcachetable to post migrate signal (CenterForOpenScience#9944) remove post-migrate signals from migration stream (CenterForOpenScience#9964) [ENG-3898][ENG-3899]Model support for OutcomeArtifact update and delete (CenterForOpenScience#9989) Make OutcomeArtifact.identifier nullable (CenterForOpenScience#9986) [ENG-3894] Outcome models (CenterForOpenScience#9975) revert color picker to working version (CenterForOpenScience#9968) # Conflicts: # api/base/settings/defaults.py # osf/apps.py # osf/migrations/0138_ensure_subjects_and_providers.py # osf/migrations/__init__.py # osf/models/provider.py # osf_tests/test_registration_bulk_upload_parser.py # website/settings/defaults.py

…OpenScience/osf.io into remove-django-debug-toolbar * 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: [ENG-3862] Move post-migrate signal out of migration stream for default providers (CenterForOpenScience#9971) [ENG-3836] Follow-up: Add PyYAML to Requirements (CenterForOpenScience#9993) [ENG-3867] Create Storage Regions on post migration signal (CenterForOpenScience#9965) [ENG-3866] Move citation style population out of migration stream (CenterForOpenScience#9966) [ENG-3868] Move blocked email domains to post-migrate signal (CenterForOpenScience#9958) [ENG-3863] Move schema ensuring and schema blocks update to post-migrate signals (CenterForOpenScience#9974) [ENG-3865] Create Licenses using post-migrate signal (CenterForOpenScience#9961) [ENG-3836] Investigate waffle flags (CenterForOpenScience#9950) move createcachetable to post migrate signal (CenterForOpenScience#9944) remove post-migrate signals from migration stream (CenterForOpenScience#9964) [ENG-3898][ENG-3899]Model support for OutcomeArtifact update and delete (CenterForOpenScience#9989) Make OutcomeArtifact.identifier nullable (CenterForOpenScience#9986) [ENG-3894] Outcome models (CenterForOpenScience#9975) revert color picker to working version (CenterForOpenScience#9968) # Conflicts: # osf/apps.py # osf/migrations/__init__.py # osf_tests/test_registration_bulk_upload_parser.py

…f.io into django-3-upgrade * 'upgrade-markdown' of https://github.com/johnetordoff/osf.io: upgrade markdown [ENG-3867] Create Storage Regions on post migration signal (CenterForOpenScience#9965) [ENG-3866] Move citation style population out of migration stream (CenterForOpenScience#9966) [ENG-3868] Move blocked email domains to post-migrate signal (CenterForOpenScience#9958) [ENG-3863] Move schema ensuring and schema blocks update to post-migrate signals (CenterForOpenScience#9974) [ENG-3865] Create Licenses using post-migrate signal (CenterForOpenScience#9961) [ENG-3836] Investigate waffle flags (CenterForOpenScience#9950) move createcachetable to post migrate signal (CenterForOpenScience#9944) remove post-migrate signals from migration stream (CenterForOpenScience#9964)

…ff/osf.io into django-3-onmibus * 'upgrade-cors-django-3' of https://github.com/johnetordoff/osf.io: upgrade CORS for Django 3 [ENG-3867] Create Storage Regions on post migration signal (CenterForOpenScience#9965) [ENG-3866] Move citation style population out of migration stream (CenterForOpenScience#9966) [ENG-3868] Move blocked email domains to post-migrate signal (CenterForOpenScience#9958) [ENG-3863] Move schema ensuring and schema blocks update to post-migrate signals (CenterForOpenScience#9974) [ENG-3865] Create Licenses using post-migrate signal (CenterForOpenScience#9961) [ENG-3836] Investigate waffle flags (CenterForOpenScience#9950) move createcachetable to post migrate signal (CenterForOpenScience#9944) remove post-migrate signals from migration stream (CenterForOpenScience#9964) # Conflicts: # admin/base/settings/defaults.py # api/base/settings/defaults.py # osf/apps.py # osf/migrations/0037_ensure_licenses.py # osf/migrations/0038_ensure_schemas.py # osf/migrations/0074_parse_citation_styles.py # osf/migrations/0077_ensure_schemas.py # osf/migrations/0078_ensure_schemas.py # osf/migrations/0080_ensure_schemas.py # osf/migrations/0083_add_ember_waffle_flags.py # osf/migrations/0095_add_url_to_licenses.py # osf/migrations/0095_ensure_licenses.py # osf/migrations/0096_ensure_schemas.py # osf/migrations/0099_add_default_storage_region.py # osf/migrations/0107_add_dependent_styles.py # osf/migrations/0112_ensure_schemas.py # osf/migrations/0121_remove_support_page_waffle_flag.py # osf/migrations/0121_remove_waffle_flags.py # osf/migrations/0135_user_settings_waffles.py # osf/migrations/0136_add_ember_auth_register_waffle_flag.py # osf/migrations/0136_preprint_node_divorce.py # osf/migrations/0137_transfer_preprint_service_permissions.py # osf/migrations/0138_ensure_subjects_and_providers.py # osf/migrations/0142_change_registration_schemas.py # osf/migrations/0142_remove_forks_flag.py # osf/migrations/0142_remove_waffle_analytics_flags.py # osf/migrations/0144_add_prereg_winddown_switches.py # osf/migrations/0147_blacklistedemaildomain.py # osf/migrations/0149_add_datacite_doi_switch.py # osf/migrations/0152_ensure_schemas.py # osf/migrations/0154_remove_ember_project_registrations_flag.py # osf/migrations/0156_create_cache_table.py # osf/migrations/0157_add_storage_usage_flag.py # osf/migrations/0162_post_migrate.py # osf/migrations/0167_auto_20190506_1556.py # osf/migrations/0170_ensure_schemas.py # osf/migrations/0172_ensure_schemas.py # osf/migrations/0173_ensure_schemas.py # osf/migrations/0174_add_ab_testing_home_page_version_b_flag.py # osf/migrations/0191_migrate_schemas_to_schemablocks.py # osf/migrations/0195_add_enable_chronos_waffle_flag.py # osf/migrations/0196_update_schemas.py # osf/migrations/0197_add_ab_testing_home_page_hero_text_version_b_flag.py # osf/migrations/0199_draft_node_permissions.py # osf/migrations/0201_add_egap_flag.py # osf/migrations/0204_ensure_schemas.py # osf/migrations/0207_ensure_schemas.py # osf/migrations/0207_update_schemas2.py # osf/migrations/0208_update_EGAP_schema.py # osf/migrations/0221_add_schemas.py # osf/migrations/0227_add_secondary_data.py # osf/migrations/__init__.py # osf_tests/test_registration_bulk_upload_parser.py # requirements.txt

) * Move loading of citation styles to post-migration signal * Peg repo to commit SHA * Attempt to speed things up by loading fixture * Move update_citation_styles to management command * Remove old test like thing * Clean up URL setting and docstring * Remove install bower from CI setup * Reorder imports * Reintroduce tests, but test skip them * Final clean-up Co-authored-by: John Tordoff <> Co-authored-by: Longze Chen <cslzchen@gmail.com>

PRs: * remove post-migrate signals from migration stream (#9964) * move createcachetable to post migrate signal (#9944) * [ENG-3836] Investigate waffle flags (#9950) * [ENG-3865] Create Licenses using post-migrate signal (#9961) * [ENG-3863] Move schema ensuring and schema blocks update to post-migrate signals (#9974) * [ENG-3868] Move blocked email domains to post-migrate signal (#9958) * [ENG-3866] Move citation style population out of migration stream (#9966) * [ENG-3867] Create Storage Regions on post migration signal (#9965) * [ENG-3836] Follow-up: Add PyYAML to Requirements (#9993) * [ENG-3862] Move post-migrate signal out of migration stream for default providers (#9971) * Remove unused password change view/route (#9985) * Update import paths and fix deprecated modules for Django 3 (#9983) * Update postgres backend and remove failover router for Django 3 (#10011) * Move file metadata population to unit test fixtures (#9994) * [Django Upgrade] Fix one sub-query slicing issue (#10012) * [Django Upgrade] Upgrade django-elasticsearch-metrics (#10021) * [Django Upgrade] Replace M2M direct assignment (#10010) * [Django Upgrade] Upgrade markdown and mdx_del_ins (#9984) * [Django Upgrade] Move schema activeness/visibility update to pytest fixtures (#10029) Commits: * Remove osf migrations * Remove addon migrations * Init migrations - osf * Init migrations - addons * Fix migration for NotableEmailDomain * Fix circular import with built-in admin migrations * Add a RunSQL migration to update indexes * Upgrade django to 3.2.15 (and related dependencies) * Make fields defined on typedmodels subclasses nullable * Add required on_delete=CASCADE (default) to FKs missing it * Fix django CORS whitelist settings due to origin definition update * Add/Enable missing templates and middlewares in api settings * Comment out admin permissions that clash with built-in "view" ones * Add migrations for django upgrade base fixes * Fix system check warnings for django admin * Fix django cache table creation * Enable django.contrib.sessions.middleware.SessionMiddleware * Use default truthy and falsy values from upgraded DRF 3.13.1 * Use JsonField from django.db.models and django.forms * Fix session cookie encoding/decoding by using ensure_str() * Use prefetch instead of Django include * Fix CORS for ORIGINS_WHITELIST * Rename auto generated migration for django3 upgrade fixes * Remove QuickFile check from get_serializer_class for FileDetail view * Add registration_schema to DraftRegistrationDetailSerializer * Add id to DraftRegistrationDetailSerializer * Fix middleware order and replace deprecated staticfiles with static * Fix and rework from_db_value & to_python for EncryptedJSONField * Fix admin login failure for django upgrade * Wrap generated keen_read_key with ensure_str * Clear cached storage region property when creating a new version * Do not notify in set_password() when creating a test user * Fix RegistrationFactory for django3 upgrade * Remove unused update_version_metadata in file node and update tests * Remove tests for django-include * Remove EGAP backfill command and tests * Set DEFAULT_AUTO_FIELD to django.db.models.AutoField (default value) * Replace deprecated NullBooleanField + add migrations * Replace deprecated url() with re_path() for api * Replace deprecated url() with re_path() for admin * Fix missing or insufficient permission test for admin preprints view * Fix admin user view tests by using HTTP response headers object * Fix duplicate view_node permissions in node and instn view tests * Rework refresh_from_db() to reload GFKs * Fix visible contributor query * Fix handle_archive_fail and its tests * Use a different schema to fix tests failure due to django3 upgrade * Update URLs for URL Validation tests with Django 3 * Improve to_internal_value() in NodeRelationshipField * Add alt fixtures to prevent both siblings & parent/child conflicts * Fix linked_by_nodes in node related counts test * Fix bugged NullBooleanField -> BooleanField migration * Re-make migrations for django3 upgrade and merge them into one Co-authored-by: Longze Chen <cslzchen@gmail.com> Co-authored-by: John Tordoff <johnetordoff@gmail.com> Co-authored-by: Jon Walz <jonmwalz@gmail.com>

Johnetordoff force-pushed the signals-citation-styles branch 6 times, most recently from 04c45ae to 77432d8 Compare June 27, 2022 19:35

jwalz reviewed Jul 1, 2022

View reviewed changes

Comment thread osf/migrations/__init__.py Outdated

Johnetordoff force-pushed the signals-citation-styles branch from 3a5498d to 7fa1a15 Compare July 3, 2022 21:26

Johnetordoff marked this pull request as ready for review July 3, 2022 22:25

Johnetordoff force-pushed the signals-citation-styles branch 10 times, most recently from 88718b2 to 6969aa4 Compare July 8, 2022 14:13

Johnetordoff commented Jul 8, 2022

View reviewed changes

Comment thread osf/management/commands/sync_citation_styles.py Outdated

cslzchen reviewed Jul 12, 2022

View reviewed changes

cslzchen approved these changes Jul 12, 2022

View reviewed changes

jwalz reviewed Jul 12, 2022

View reviewed changes

cslzchen approved these changes Jul 13, 2022

View reviewed changes

John Tordoff added 6 commits July 14, 2022 15:35

Move loading of citation styles to post-migration signal

b8e3766

Peg repo to commit SHA

5a1f7da

Attempt to speed things up by loading fixture

cb1819e

Move update_citation_styles to management command

b1b8e62

Remove old test like thing

b0939e3

Clean up UR0 setting and docstring

88852ea

cslzchen force-pushed the signals-citation-styles branch from 76d8f24 to 1a89214 Compare July 14, 2022 19:59

Trivial clean-up

3be3cdb

cslzchen approved these changes Jul 14, 2022

View reviewed changes

cslzchen merged commit 2c751d1 into CenterForOpenScience:feature/django_upgrade Jul 15, 2022

Johnetordoff commented Jul 15, 2022

View reviewed changes

Conversation

Johnetordoff commented Jun 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Changes

QA Notes

Documentation

Side Effects

Ticket

Uh oh!

Uh oh!

Uh oh!

cslzchen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cslzchen left a comment

Choose a reason for hiding this comment

Uh oh!

jwalz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cslzchen left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cslzchen left a comment

Choose a reason for hiding this comment

Uh oh!

Johnetordoff Jul 15, 2022

Choose a reason for hiding this comment

Uh oh!

cslzchen Jul 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Johnetordoff commented Jun 27, 2022 •

edited

Loading

cslzchen left a comment •

edited

Loading

cslzchen Jul 15, 2022 •

edited

Loading