[ENG-3862][Take 2] Move post-migrate signal out of migration stream for default providers by Johnetordoff · Pull Request #9971 · CenterForOpenScience/osf.io

Johnetordoff · 2022-07-07T12:15:41Z

Purpose

This is second PR to explore the different provider population options.

Changes

QA Notes

Please make verification statements inspired by your code and what your code touches.

Verify
Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

https://openscience.atlassian.net/browse/ENG-3862

cslzchen

Noticed one concern during my final review 🔥

cslzchen

See #9971 (comment)

cslzchen

I cherry-picked 15d01fbf6137190c6103890f4eeba7b0d7787e4d into 411b60a and all looks good 🎆

…OpenScience/osf.io into upguard-indexes * 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: [ENG-3862] Move post-migrate signal out of migration stream for default providers (CenterForOpenScience#9971) # Conflicts: # osf/migrations/0138_ensure_subjects_and_providers.py # osf/migrations/__init__.py # osf/models/provider.py # osf_tests/test_registration_bulk_upload_parser.py

…OpenScience/osf.io into upgrade-django-misc * 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: [ENG-3862] Move post-migrate signal out of migration stream for default providers (CenterForOpenScience#9971)

…OpenScience/osf.io into upgrade-markdown * 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: [ENG-3862] Move post-migrate signal out of migration stream for default providers (CenterForOpenScience#9971)

…OpenScience/osf.io into upgrade-password-reset * 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: [ENG-3862] Move post-migrate signal out of migration stream for default providers (CenterForOpenScience#9971)

…OpenScience/osf.io into upguard-indexes * 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: [ENG-3862] Move post-migrate signal out of migration stream for default providers (CenterForOpenScience#9971) # Conflicts: # osf/migrations/0138_ensure_subjects_and_providers.py # osf/migrations/__init__.py # osf/models/provider.py # osf_tests/test_registration_bulk_upload_parser.py

…OpenScience/osf.io into upgrade-django-misc * 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: [ENG-3862] Move post-migrate signal out of migration stream for default providers (CenterForOpenScience#9971)

…OpenScience/osf.io into django-3-with-django-include * 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: [ENG-3862] Move post-migrate signal out of migration stream for default providers (CenterForOpenScience#9971) [ENG-3836] Follow-up: Add PyYAML to Requirements (CenterForOpenScience#9993) [ENG-3867] Create Storage Regions on post migration signal (CenterForOpenScience#9965) [ENG-3866] Move citation style population out of migration stream (CenterForOpenScience#9966) [ENG-3868] Move blocked email domains to post-migrate signal (CenterForOpenScience#9958) [ENG-3863] Move schema ensuring and schema blocks update to post-migrate signals (CenterForOpenScience#9974) [ENG-3865] Create Licenses using post-migrate signal (CenterForOpenScience#9961) [ENG-3836] Investigate waffle flags (CenterForOpenScience#9950) move createcachetable to post migrate signal (CenterForOpenScience#9944) remove post-migrate signals from migration stream (CenterForOpenScience#9964) [ENG-3898][ENG-3899]Model support for OutcomeArtifact update and delete (CenterForOpenScience#9989) Make OutcomeArtifact.identifier nullable (CenterForOpenScience#9986) [ENG-3894] Outcome models (CenterForOpenScience#9975) revert color picker to working version (CenterForOpenScience#9968) # Conflicts: # api/base/settings/defaults.py # osf/apps.py # osf/migrations/0138_ensure_subjects_and_providers.py # osf/migrations/__init__.py # osf/models/provider.py # osf_tests/test_registration_bulk_upload_parser.py # website/settings/defaults.py

…OpenScience/osf.io into remove-django-debug-toolbar * 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: [ENG-3862] Move post-migrate signal out of migration stream for default providers (CenterForOpenScience#9971) [ENG-3836] Follow-up: Add PyYAML to Requirements (CenterForOpenScience#9993) [ENG-3867] Create Storage Regions on post migration signal (CenterForOpenScience#9965) [ENG-3866] Move citation style population out of migration stream (CenterForOpenScience#9966) [ENG-3868] Move blocked email domains to post-migrate signal (CenterForOpenScience#9958) [ENG-3863] Move schema ensuring and schema blocks update to post-migrate signals (CenterForOpenScience#9974) [ENG-3865] Create Licenses using post-migrate signal (CenterForOpenScience#9961) [ENG-3836] Investigate waffle flags (CenterForOpenScience#9950) move createcachetable to post migrate signal (CenterForOpenScience#9944) remove post-migrate signals from migration stream (CenterForOpenScience#9964) [ENG-3898][ENG-3899]Model support for OutcomeArtifact update and delete (CenterForOpenScience#9989) Make OutcomeArtifact.identifier nullable (CenterForOpenScience#9986) [ENG-3894] Outcome models (CenterForOpenScience#9975) revert color picker to working version (CenterForOpenScience#9968) # Conflicts: # osf/apps.py # osf/migrations/__init__.py # osf_tests/test_registration_bulk_upload_parser.py

…lt providers (#9971) * Remove default provider population from migration to post-migrate signal * Add conditional from local env * Load with get_default and refactor * Fix rebase conflicts: settings -> osf_settings * Remove subjects population Co-authored-by: John Tordoff <> Co-authored-by: Longze Chen <cslzchen@gmail.com>

PRs: * remove post-migrate signals from migration stream (#9964) * move createcachetable to post migrate signal (#9944) * [ENG-3836] Investigate waffle flags (#9950) * [ENG-3865] Create Licenses using post-migrate signal (#9961) * [ENG-3863] Move schema ensuring and schema blocks update to post-migrate signals (#9974) * [ENG-3868] Move blocked email domains to post-migrate signal (#9958) * [ENG-3866] Move citation style population out of migration stream (#9966) * [ENG-3867] Create Storage Regions on post migration signal (#9965) * [ENG-3836] Follow-up: Add PyYAML to Requirements (#9993) * [ENG-3862] Move post-migrate signal out of migration stream for default providers (#9971) * Remove unused password change view/route (#9985) * Update import paths and fix deprecated modules for Django 3 (#9983) * Update postgres backend and remove failover router for Django 3 (#10011) * Move file metadata population to unit test fixtures (#9994) * [Django Upgrade] Fix one sub-query slicing issue (#10012) * [Django Upgrade] Upgrade django-elasticsearch-metrics (#10021) * [Django Upgrade] Replace M2M direct assignment (#10010) * [Django Upgrade] Upgrade markdown and mdx_del_ins (#9984) * [Django Upgrade] Move schema activeness/visibility update to pytest fixtures (#10029) Commits: * Remove osf migrations * Remove addon migrations * Init migrations - osf * Init migrations - addons * Fix migration for NotableEmailDomain * Fix circular import with built-in admin migrations * Add a RunSQL migration to update indexes * Upgrade django to 3.2.15 (and related dependencies) * Make fields defined on typedmodels subclasses nullable * Add required on_delete=CASCADE (default) to FKs missing it * Fix django CORS whitelist settings due to origin definition update * Add/Enable missing templates and middlewares in api settings * Comment out admin permissions that clash with built-in "view" ones * Add migrations for django upgrade base fixes * Fix system check warnings for django admin * Fix django cache table creation * Enable django.contrib.sessions.middleware.SessionMiddleware * Use default truthy and falsy values from upgraded DRF 3.13.1 * Use JsonField from django.db.models and django.forms * Fix session cookie encoding/decoding by using ensure_str() * Use prefetch instead of Django include * Fix CORS for ORIGINS_WHITELIST * Rename auto generated migration for django3 upgrade fixes * Remove QuickFile check from get_serializer_class for FileDetail view * Add registration_schema to DraftRegistrationDetailSerializer * Add id to DraftRegistrationDetailSerializer * Fix middleware order and replace deprecated staticfiles with static * Fix and rework from_db_value & to_python for EncryptedJSONField * Fix admin login failure for django upgrade * Wrap generated keen_read_key with ensure_str * Clear cached storage region property when creating a new version * Do not notify in set_password() when creating a test user * Fix RegistrationFactory for django3 upgrade * Remove unused update_version_metadata in file node and update tests * Remove tests for django-include * Remove EGAP backfill command and tests * Set DEFAULT_AUTO_FIELD to django.db.models.AutoField (default value) * Replace deprecated NullBooleanField + add migrations * Replace deprecated url() with re_path() for api * Replace deprecated url() with re_path() for admin * Fix missing or insufficient permission test for admin preprints view * Fix admin user view tests by using HTTP response headers object * Fix duplicate view_node permissions in node and instn view tests * Rework refresh_from_db() to reload GFKs * Fix visible contributor query * Fix handle_archive_fail and its tests * Use a different schema to fix tests failure due to django3 upgrade * Update URLs for URL Validation tests with Django 3 * Improve to_internal_value() in NodeRelationshipField * Add alt fixtures to prevent both siblings & parent/child conflicts * Fix linked_by_nodes in node related counts test * Fix bugged NullBooleanField -> BooleanField migration * Re-make migrations for django3 upgrade and merge them into one Co-authored-by: Longze Chen <cslzchen@gmail.com> Co-authored-by: John Tordoff <johnetordoff@gmail.com> Co-authored-by: Jon Walz <jonmwalz@gmail.com>

Johnetordoff marked this pull request as ready for review July 9, 2022 23:50

jwalz reviewed Jul 12, 2022

View reviewed changes

Comment thread osf/migrations/__init__.py

Comment thread osf/migrations/__init__.py

cslzchen reviewed Jul 12, 2022

View reviewed changes

Comment thread osf/models/provider.py Outdated

Johnetordoff force-pushed the signal-create-providers-2 branch 5 times, most recently from b907f79 to 6a9ad7a Compare July 22, 2022 15:13

cslzchen reviewed Jul 26, 2022

View reviewed changes

Comment thread osf_tests/test_registration_bulk_upload_parser.py

Comment thread osf/migrations/__init__.py

Comment thread osf/migrations/0138_ensure_subjects_and_providers.py

cslzchen force-pushed the feature/django_upgrade branch from 65b0360 to 250b832 Compare July 27, 2022 19:20

cslzchen force-pushed the signal-create-providers-2 branch from 0fea5d1 to 6d5b18f Compare July 27, 2022 21:12

John Tordoff added 3 commits July 27, 2022 17:14

remove default provider population from migration to post-migrate signal

7ee4d05

add conditional from local env

f333152

load with get_default and refactor

e430c2e

cslzchen force-pushed the signal-create-providers-2 branch from 6d5b18f to e430c2e Compare July 27, 2022 21:14

Fix rebase conflicts: settings -> osf_settings

c472c2d

cslzchen requested changes Jul 27, 2022

View reviewed changes

Johnetordoff force-pushed the signal-create-providers-2 branch from c472c2d to 15d01fb Compare July 27, 2022 21:37

remove subjects population

411b60a

cslzchen force-pushed the signal-create-providers-2 branch from 0660254 to 411b60a Compare July 28, 2022 19:47

cslzchen approved these changes Jul 28, 2022

View reviewed changes

cslzchen merged commit 65b344b into CenterForOpenScience:feature/django_upgrade Jul 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ENG-3862][Take 2] Move post-migrate signal out of migration stream for default providers#9971

[ENG-3862][Take 2] Move post-migrate signal out of migration stream for default providers#9971
cslzchen merged 5 commits into
CenterForOpenScience:feature/django_upgradefrom
Johnetordoff:signal-create-providers-2

Johnetordoff commented Jul 7, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cslzchen left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cslzchen left a comment

Uh oh!

cslzchen left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Johnetordoff commented Jul 7, 2022

Purpose

Changes

QA Notes

Documentation

Side Effects

Ticket

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cslzchen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cslzchen left a comment

Choose a reason for hiding this comment

Uh oh!

cslzchen left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants