Skip to content

Conversation

@pedrouid
Copy link
Member

@pedrouid pedrouid commented May 30, 2024

Standardized messaging for wallet interface in browser environments.

@pedrouid pedrouid changed the title Browser wallet messaging interface CAIP-282 - Browser Wallet Messaging Interface May 30, 2024
pedrouid and others added 4 commits May 30, 2024 13:34
Co-authored-by: Chris Smith <1979423+chris13524@users.noreply.github.com>
Co-authored-by: Chris Smith <1979423+chris13524@users.noreply.github.com>
pedrouid and others added 8 commits June 6, 2024 13:39
Co-authored-by: Derek <alexanderderekrein@gmail.com>
Co-authored-by: Derek <alexanderderekrein@gmail.com>
Co-authored-by: Derek <alexanderderekrein@gmail.com>
Co-authored-by: Derek <alexanderderekrein@gmail.com>
Co-authored-by: Derek <alexanderderekrein@gmail.com>
@obstropolos obstropolos requested a review from bumblefudge June 6, 2024 23:21
Copy link
Contributor

@obstropolos obstropolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A number of feedback across the spec - nothing too deep other than just a few consistency items / etc.

pedrouid and others added 3 commits June 7, 2024 15:40
Co-authored-by: Gregory Rocco <gregoryrocco1226@gmail.com>
Co-authored-by: Gregory Rocco <gregoryrocco1226@gmail.com>
Co-authored-by: Gregory Rocco <gregoryrocco1226@gmail.com>
bumblefudge and others added 2 commits February 19, 2025 14:37
thanks chris13524

Co-authored-by: Chris Smith <1979423+chris13524@users.noreply.github.com>
pedrouid and others added 5 commits May 12, 2025 12:18
Co-authored-by: jiexi <jiexiluan@gmail.com>
Co-authored-by: jiexi <jiexiluan@gmail.com>
…interface-update

Update caip-294 to fit extension id as valid target type (caip-341)
Copy link
Member Author

@pedrouid pedrouid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

Copy link
Collaborator

@bumblefudge bumblefudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly Approved but there are still a few nits I couldn't fix myself and a few threads that it felt wrong to "resolve"... @pedrouid another 10min should get this over the line for me and on to ligi or al or obstropolous for final approval

@bumblefudge
Copy link
Collaborator

bumblefudge commented May 19, 2025

LGTM 👌

I assume you meant this for the upstream PR onto this branch?

pedrouid and others added 2 commits July 31, 2025 13:32
Co-authored-by: Alex Donesky <alex.donesky@consensys.net>
@obstropolos
Copy link
Contributor

Mostly Approved but there are still a few nits I couldn't fix myself and a few threads that it felt wrong to "resolve"... @pedrouid another 10min should get this over the line for me and on to ligi or al or obstropolous for final approval

@pedrouid bump

@bumblefudge bumblefudge merged commit 36ef9ee into ChainAgnostic:main Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.