-
Notifications
You must be signed in to change notification settings - Fork 216
CAIP-282 - Browser Wallet Messaging Interface #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAIP-282 - Browser Wallet Messaging Interface #282
Conversation
Co-authored-by: Chris Smith <1979423+chris13524@users.noreply.github.com>
Co-authored-by: Chris Smith <1979423+chris13524@users.noreply.github.com>
…om/pedrouid/CAIPs into browser-wallet-messaging-interface
Co-authored-by: Derek <alexanderderekrein@gmail.com>
Co-authored-by: Derek <alexanderderekrein@gmail.com>
Co-authored-by: Derek <alexanderderekrein@gmail.com>
Co-authored-by: Derek <alexanderderekrein@gmail.com>
Co-authored-by: Derek <alexanderderekrein@gmail.com>
obstropolos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A number of feedback across the spec - nothing too deep other than just a few consistency items / etc.
Co-authored-by: Gregory Rocco <gregoryrocco1226@gmail.com>
Co-authored-by: Gregory Rocco <gregoryrocco1226@gmail.com>
Co-authored-by: Gregory Rocco <gregoryrocco1226@gmail.com>
thanks chris13524 Co-authored-by: Chris Smith <1979423+chris13524@users.noreply.github.com>
…wallet-messaging-interface-update
Co-authored-by: jiexi <jiexiluan@gmail.com>
Co-authored-by: jiexi <jiexiluan@gmail.com>
…interface-update Update caip-294 to fit extension id as valid target type (caip-341)
pedrouid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
bumblefudge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly Approved but there are still a few nits I couldn't fix myself and a few threads that it felt wrong to "resolve"... @pedrouid another 10min should get this over the line for me and on to ligi or al or obstropolous for final approval
I assume you meant this for the upstream PR onto this branch? |
Co-authored-by: Alex Donesky <alex.donesky@consensys.net>
Co-authored-by: Bumblefudge <caballerojuan@pm.me>
Standardized messaging for wallet interface in browser environments.