Skip to content

feat(benchmarks): add benchmarks and specific weights to all pallets#91

Merged
clearloop merged 32 commits intomainfrom
cl/benchmarks
Jun 8, 2021
Merged

feat(benchmarks): add benchmarks and specific weights to all pallets#91
clearloop merged 32 commits intomainfrom
cl/benchmarks

Conversation

@clearloop
Copy link
Contributor

@clearloop clearloop commented May 31, 2021

Changes

  • Update the registry of pallet-chainlink-feed to Chainsafe/chainlink-polkadot

benchmarking.rs

  • asset-depository ( no calls )
  • asset-index ( this pallet is buggy )
  • committee
  • local-treasury
  • price-feed
  • remote-asset-manager ( incomplete )
  • saft-registry
  • xcm-asset-support ( no calls )

default_weight.rs

verify

Tests

# CI

Issues

Closes #80

Ref #64

@dutterbutter dutterbutter added the WIP Work in progress - do not review or merge label Jun 3, 2021
@clearloop clearloop marked this pull request as ready for review June 5, 2021 06:57
@clearloop clearloop added needs review PR needs reviewing and removed WIP Work in progress - do not review or merge labels Jun 5, 2021
@clearloop clearloop requested a review from mattsse June 7, 2021 11:49
Copy link
Contributor

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this looks great!
Only minor nits, and one question about the From<u32> restriction, was this necessary for the benchmarks?
I don't think we should necessarily restrict it to be an u32, for example it could be end up something like Acala's currencyId

https://github.com/AcalaNetwork/Acala/blob/master/primitives/src/currency.rs#L208-L212

@clearloop
Copy link
Contributor Author

I don't think we should necessarily restrict it to be an u32, for example it could be end up something like Acala's currencyId

https://github.com/AcalaNetwork/Acala/blob/master/primitives/src/currency.rs#L208-L212

Agree, if we implement something like CurrencyId, should we set up a new PR for this?

@mattsse mattsse added approved PR approved to merge and removed needs review PR needs reviewing labels Jun 8, 2021
@clearloop clearloop merged commit 455d3f0 into main Jun 8, 2021
@clearloop clearloop deleted the cl/benchmarks branch June 8, 2021 11:18
@mattsse
Copy link
Contributor

mattsse commented Jun 8, 2021

Agree, if we implement something like CurrencyId, should we set up a new PR for this?

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR approved to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add runtime benchmarks and pallet specific weights

3 participants