`AssetPriceFeed not found` in the call `deposit` of pallet `asset-index`

[clearloop]

Issue summary

This deposit function runs well in tests, but not in benchmarks, besides, met this issue also while I was writing the Javascript API of PINT in #83.

Guess need to ensure that a valid round has already submitted first, separating from #91

Other information and links

• PINT/pallets/asset-index/src/tests.rs

  Line 91 in 4fcfc4f

  fn deposit_only_works_for_added_liquid_assets() {

• PINT/pallets/price-feed/src/lib.rs

  Line 175 in 4fcfc4f

  AssetPriceFeedNotFound,

---

Could not use pallet_chainlink_feed in the benchmark of pallet_asset_index, these two pallets are not tight coupling, #94

[mattsse]

A deposit of a specific (liquid) asset is essentially a conversion from this very asset to PINT token.
In order to determine the PINT/asset rate, a price feed for this asset is required, hence the error.

Before depositing an asset its price pair must have at least a valid round.

For testing purposes, a mock price feed is used:

https://github.com/ChainSafe/PINT/blob/main/pallets/asset-index/src/mock.rs#L174-L199

We could also depend on our price pair crate wich exports a Feedbuilder

https://github.com/ChainSafe/PINT/blob/main/pallets/price-feed/src/mock.rs#L132

[clearloop]

For testing purposes, a mock price feed is used:

https://github.com/ChainSafe/PINT/blob/main/pallets/asset-index/src/mock.rs#L174-L199

We could also depend on our price pair crate wich exports a Feedbuilder

https://github.com/ChainSafe/PINT/blob/main/pallets/price-feed/src/mock.rs#L132

Yep, but we can use ChainlinkFeed<T> in mock tests but not in benchmarks, for example, in asset-index

trait Config: frame_system::Config {

}

We only can use AssetIndex<T> and System<T> but not ChainlinkFeed<T>, because we don't have this trait bound in the Config of asset-index

[mattsse]

In the runtime this is configured like this:

https://github.com/ChainSafe/PINT/blob/main/runtime/src/lib.rs#L551

https://github.com/ChainSafe/PINT/blob/main/runtime/src/lib.rs#L656

So basically asset-index > price-feed > chainlink-feed

[clearloop]

In the runtime this is configured like this:

https://github.com/ChainSafe/PINT/blob/main/runtime/src/lib.rs#L551

https://github.com/ChainSafe/PINT/blob/main/runtime/src/lib.rs#L656

So basically asset-index > price-feed > chainlink-feed

https://matrix.to/#/!HzySYSaIhtyWrwiwEV:matrix.org/$162279373731624DqCxU:matrix.org?via=matrix.parity.io&via=matrix.org&via=corepaper.org

Yep, but we can call ChainlinkFeed<T> in the benchmark of pallet asset-index only if AssetIndex<T: pallet_chainlink_feed::Config>