ci(e2e): E2E tests with CI integration by clearloop · Pull Request #83 · ChainSafe/PINT

clearloop · 2021-05-20T13:13:36Z

Changes

E2E tests for PINT, ref https://github.com/AcalaNetwork/Acala/blob/master/launch/src/index.js

Process ( in Docker )
- Requires a binary of PINT as a forked process ( after building completed in CI )
- Test suit
E2E tests in CircleCI

Tests

WIP

Issues

Ref #81

clearloop · 2021-06-15T11:21:44Z

js/e2e/index.ts

+// Tests
+const TESTS = (api: ApiPromise): Extrinsic[] => [
+    {
+        pallet: "assetIndex",
+        call: "addAsset",
+        args: [
+            42,
+            1000000,
+            api.createType("AssetAvailability" as any),
+            1000000,
+        ],
+    },
+];


We can configure our api tests here in the future

mattsse

This looks great, I'm just hesitant to add polkadot-launch as a submodule, can we use this as node_module instead?

mattsse · 2021-06-15T14:12:43Z

.gitmodules

+[submodule "js/polkadot-launch"]
+	path = js/polkadot-launch
+	url = https://github.com/paritytech/polkadot-launch.git


Do we really need this as a submodule?

mattsse · 2021-06-15T14:14:34Z

js/e2e/src/launch.ts

+ * @returns {Promise<ChildProcess>}
+ */
+export async function local(stdio?: StdioOptions): Promise<ChildProcess> {
+    return fork("js/polkadot-launch", ["config.json"], {


can't we youse polkadot-lauch directly?

The npm package of polkadot-launch is outdated

If we use git url as a dependency

The git repo of polkadot-launch is really big ( over 200MB ), because it contains binaries in its git history

that's unfortunate. But as submodule we'd have to check it out anyways, so using the repo directly in package.json makes more sense to me

I tried using polkadot-launch as a dependency before, and npm hardly can fetch polkadot-launch on my machine, let me try it on CI

https://app.circleci.com/pipelines/github/ChainSafe/PINT/291/workflows/9f4b1a78-4d4a-4e37-a22c-58f4d2dcc97c/jobs/1492

Hardly can fetch

mattsse · 2021-06-15T14:15:19Z

js/pint-types-bundle/LICENSE

@@ -0,0 +1,165 @@
+                   GNU LESSER GENERAL PUBLIC LICENSE


symlink instead ln -s ../../LICENSE ?

if we use ln -s ../../LICENSE, it will be

$ cat LICENSE cat: LICENSE: Too many levels of symbolic links

hmm is there a loop somewhere.
nvm, let's just copy it then

For example

https://app.circleci.com/pipelines/github/ChainSafe/PINT/290/workflows/e0620c11-c90d-4701-8e4e-e3a6e4a03b7c/jobs/1486

This reverts commit ea817b6. Revert "ci(e2e): clone polkadot-launch in container" This reverts commit 610d795. Revert "feat(js/e2e): try require polkadot-launch as a dependency" This reverts commit f8a0e47. Revert "chore(js): use symlink type for LICNESE" This reverts commit 700b4f6.

mattsse · 2021-06-16T08:54:39Z

.gitmodules

+[submodule "js/polkadot-launch"]
+	path = js/polkadot-launch
+	url = https://github.com/paritytech/polkadot-launch.git


This is obsolete now, right? since we checkout during build?

This still exists QAQ,

#83 (comment)

We could not avoid using the submodule in the current state I think, because the CI can not fetch this repo as well

I see, guess we'd have to live with it for now.

This is obsolete now, right? since we checkout during build?

OO, This will not be loaded into our directory unless we git submodule update --init

clearloop added 3 commits May 20, 2021 21:02

feat(e2e): init typescript for e2e tests

fe7cef6

ci(build): build and test with release binary

ae83906

feat(e2e): abstract pint command

6aaf424

clearloop mentioned this pull request May 25, 2021

Test block finalization of parachain integration in CI #86

Closed

clearloop added 14 commits May 26, 2021 17:02

ci(docker): move docker config into folder docker

7dc726e

ci(docker): type of the path of Dockerfile

f7d782e

fead(docker): add Dockerfile for launching PINT

aeb9746

feat(e2e): use test binaries served by clearloop

4d86b9c

ci(e2e): save binaires into scratch image

1b64ca9

ci(docker): fetch binaries from dockerhub

cd483d6

ci(e2e): build e2e image in CI

a9b081c

ci(e2e): add e2e to workflow jobs

640fad8

feat(e2e): init javascript workspace

72609b8

ci(e2e): checkout before building e2e image

33e4326

feat(e2e): init tester

a3d42a4

feat(e2e): abstract result type

9afcae3

feat(e2e): define types for pallets

c480ddc

chore(js): move js packages into js folder

741883b

clearloop changed the title ~~E2E tests with CI integration~~ ci(e2e): E2E tests with CI integration May 27, 2021

clearloop added 8 commits May 27, 2021 21:27

feat(js): add polkadot-launch as submodule

1a51004

feat(js): package launch

78e1fc7

feat(e2e): traverse APIs

174c519

feat(e2e): remove launch and api

b5b2c9a

ci(e2e): squash commands in e2e

5d1d8da

feat(e2e): add e2e runner

8bbdb16

chore(e2e): reinit polkadot-launch

21f4e80

feat(e2e): launch pint as child_process

62b1e7e

dutterbutter added the WIP Work in progress - do not review or merge label Jun 3, 2021

clearloop mentioned this pull request Jun 3, 2021

AssetPriceFeed not found in the call deposit of pallet asset-index #93

Closed

feat(e2e): add kill signal to fork process

f8983ac

clearloop added 9 commits June 15, 2021 14:06

ci(e2e): unsafe-ws-external

a4d0554

ci(e2e): fix the fucking docker command

961cbeb

ci(e2e): exit 0

e2c7b40

ci(e2e): kill all subprocesses

e2c1356

chore(git): clean cargo.lock

3419ec0

Merge branch 'main' into cl/e2e

70d5b62

Merge branch 'main' into cl/e2e

68748dc

chore(runtime): fix typo in runtime

354899f

ci(e2e): handle EPERM

35dbddd

clearloop added the needs review PR needs reviewing label Jun 15, 2021

clearloop marked this pull request as ready for review June 15, 2021 11:20

clearloop commented Jun 15, 2021

View reviewed changes

clearloop removed the WIP Work in progress - do not review or merge label Jun 15, 2021

clearloop requested a review from mattsse June 15, 2021 11:23

mattsse suggested changes Jun 15, 2021

View reviewed changes

mattsse added needs changes PR needs changes and removed needs review PR needs reviewing labels Jun 15, 2021

clearloop added 5 commits June 15, 2021 22:25

chore(js): use symlink type for LICNESE

700b4f6

feat(js/e2e): try require polkadot-launch as a dependency

f8a0e47

ci(e2e): clone polkadot-launch in container

610d795

chore(js): copy license

ea817b6

clearloop added needs review PR needs reviewing and removed needs changes PR needs changes labels Jun 16, 2021

clearloop requested a review from mattsse June 16, 2021 08:28

mattsse approved these changes Jun 16, 2021

View reviewed changes

clearloop merged commit 1b94cc2 into main Jun 16, 2021

clearloop deleted the cl/e2e branch June 16, 2021 10:57

clearloop added approved PR approved to merge and removed needs review PR needs reviewing labels Jun 16, 2021

Conversation

clearloop commented May 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Tests

Issues

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mattsse left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

clearloop Jun 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

clearloop Jun 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

clearloop commented May 20, 2021 •

edited

Loading

clearloop Jun 16, 2021 •

edited

Loading

clearloop Jun 16, 2021 •

edited

Loading