Update UnitySampleProject to 2022 LTS #938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandrchainsafe
requested review from
juans-chainsafe,
kantagara,
rob1997 and
sneakzttv
Contributor
Author
|
@juans-chainsafe Please "Ensure all features are working as before across all platforms" |
sneakzttv
approved these changes
May 3, 2024
juans-chainsafe
suggested changes
May 3, 2024
Contributor
juans-chainsafe
left a comment
juans-chainsafe
left a comment
There was a problem hiding this comment.
I didnt finish the whole testing, but this is the feedback so far:
- Editor with web3auth + samples + logout + remember me ✅
- Editor with wallet connect + samples + logout + remember me ✅
- Isolated Lootbox scene (without login) in editor ✅
- WebGL with metamask login + samples + logout ✅
❌ Issues:
- Ramp is not working in WebGL, neither metamask login or web3auth, loading spinner is stuck in a loop:
- Samples that require sign a transaction like GetNonce, Mint or Transfer in WebGL with web3auth:
Invoking error handler due to
RuntimeError: null function or function signature mismatch
Stuff that I can't test due to previous errors:
PENDING:
- iOS with web3auth
- iOS with wallet connect
- Empty Unity project from scratch
Contributor
iOS testing:
@oleksandrchainsafe weird thing is that Ramp is working in iOS but not in WebGL. And samples that require a transaction works in iOS + web3auth but they DON'T work in WebGL + web3auth |
Collaborator
@juans-chainsafe could you check |
Contributor
|
Ramp issue on WebGL can be solved by following steps here |
juans-chainsafe
approved these changes
May 17, 2024
Contributor
juans-chainsafe
left a comment
juans-chainsafe
left a comment
There was a problem hiding this comment.
WebGL + Web3Auth issue was fixed with #963
So, we are good to go!
rob1997
approved these changes
May 17, 2024
rob1997
added
the
ready-to-merge
oleksandrchainsafe
deleted the
oleksandr/update-unitysampleproject-to-2022-lts
branch
Merged
rob1997
added a commit
that referenced
this pull request
Jan 16, 2025
Updated UnitySampleProject version to 2022.3.26f1 Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: Nikola Garabandic <kantagara@gmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: Juan Manuel Spoleti <104365141+juans-chainsafe@users.noreply.github.com>
sergeypanin1994
pushed a commit
to sergeypanin1994/web3.unity
that referenced
this pull request
Mar 16, 2025
Updated UnitySampleProject version to 2022.3.26f1 Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: Nikola Garabandic <kantagara@gmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: Juan Manuel Spoleti <104365141+juans-chainsafe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to 2022.3.26f1