Marketplace package #988
Merged
Marketplace package #988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marketplace package
Compilation conditionals added to sample scripts
Almost there
assembly defs
Package json
Defines via asmdef
auto-assign
bot
requested review from
juans-chainsafe,
kantagara,
oleksandrchainsafe and
rob1997
sneakzttv
added
the
ready-to-merge
juans-chainsafe
suggested changes
May 29, 2024
| @@ -1,2 +1,2 @@ | |||
| m_EditorVersion: 2022.3.26f1 | |||
Contributor
There was a problem hiding this comment.
we shouldn't change this
Contributor
Author
There was a problem hiding this comment.
we should all be on .22f1 right?
Contributor
Author
There was a problem hiding this comment.
updating, I removed all my versions today to avoid this lol
juans-chainsafe
previously requested changes
May 29, 2024
Contributor
juans-chainsafe
left a comment
juans-chainsafe
left a comment
There was a problem hiding this comment.
if I don't import the marketplace package into the project, I see this build errors:
Assets/Samples/web3.unity SDK/2.5.5/Web3.Unity Samples/Scripts/Scenes/SampleMain/IPFS/IPFSCalls.cs(4,7): error CS0246: The type or namespace name 'Web3Unity' could not be found (are you missing a using directive or an assembly reference?)
Assets/Samples/web3.unity SDK/2.5.5/Web3.Unity Samples/Scripts/Scenes/SampleMain/Marketplace/MarketplaceCalls.cs(1,19): error CS0234: The type or namespace name 'Marketplace' does not exist in the namespace 'Scripts.EVM' (are you missing an assembly reference?)
Contributor
Author
Compilation conditional define is being placed in there at the start, i'll need to make it remove itself on deletion. BRB. |
sneakzttv
removed
the
ready-to-merge
sneakzttv
added
the
ready-to-merge
sneakzttv
added
ready-to-merge
kantagara
reviewed
May 30, 2024
| "url": "https://gaming.chainsafe.io/" | ||
| }, | ||
| "samples": [ | ||
| { |
Contributor
There was a problem hiding this comment.
This should be an empty array
Moving IPFS back to samples & fixing package duplicates.
sneakzttv
removed
the
ready-to-merge
Remove deadfiles
rob1997
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Marketplace package Marketplace package * Compilation conditionals added to sample scripts Compilation conditionals added to sample scripts * Cleanup Cleanup * Almost there Almost there * Update DisableGameObjectIfServiceNotActive.cs * assembly defs assembly defs * Package json Package json * testing testing * Update io.chainsafe.web3-unity.marketplace.runtime.asmdef * Defines via asmdef Defines via asmdef * Adding MARKETPLACE_AVAILABLE "on demand" * Adding csc.rsp file because for our project in general should be gucci. * Login fix Login fix * Update SampleMain.unity * Update SampleMain.unity * Update CscImporter.cs * Update CscImporter.cs * Fixes Fixes * Remove debug * Fixes Fixes * Fixes * Fix Fix * Update package.json * Fix for csc.rsp * Meta file changed? * Celanup * Moving IPFS back to samples Moving IPFS back to samples & fixing package duplicates. * Update .gitignore * Update .gitignore * samples samples * Update .gitignore * Update Update * Fixes Fixes * Remove deadfiles Remove deadfiles --------- Co-authored-by: Nikola Garabandic <kantagara@gmail.com>
sergeypanin1994
pushed a commit
to sergeypanin1994/web3.unity
that referenced
this pull request
Mar 16, 2025
* Marketplace package Marketplace package * Compilation conditionals added to sample scripts Compilation conditionals added to sample scripts * Cleanup Cleanup * Almost there Almost there * Update DisableGameObjectIfServiceNotActive.cs * assembly defs assembly defs * Package json Package json * testing testing * Update io.chainsafe.web3-unity.marketplace.runtime.asmdef * Defines via asmdef Defines via asmdef * Adding MARKETPLACE_AVAILABLE "on demand" * Adding csc.rsp file because for our project in general should be gucci. * Login fix Login fix * Update SampleMain.unity * Update SampleMain.unity * Update CscImporter.cs * Update CscImporter.cs * Fixes Fixes * Remove debug * Fixes Fixes * Fixes * Fix Fix * Update package.json * Fix for csc.rsp * Meta file changed? * Celanup * Moving IPFS back to samples Moving IPFS back to samples & fixing package duplicates. * Update .gitignore * Update .gitignore * samples samples * Update .gitignore * Update Update * Fixes Fixes * Remove deadfiles Remove deadfiles --------- Co-authored-by: Nikola Garabandic <kantagara@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved IPFS & marketplace core functionality into a package to modularize it's use and left a placeholder for a use case implementation for 3.0.
To Test:
Run setup.sh
Check that the sdk functions as usual without the marketplace package.
Install the marketplace package locally and check that the marketplace/ipfs functions work there too.
The marketplace calls will enable in the sample scene similar to how ramp does once the package is present.