fix(f1): resolve ScrollHelper.reset AttributeError

[ChuckBuilds]

Description

Fixes 'ScrollHelper' object has no attribute 'reset' error that prevented the F1 plugin from displaying qualifying positions and other scroll content after the track overview.

Root Cause

The F1 and UFC plugins called scroll_helper.reset(), but the LEDMatrix ScrollHelper class exposes reset_scroll(), not reset(). Other plugins (odds-ticker, football-scoreboard, hockey-scoreboard, soccer-scoreboard) already use reset_scroll() correctly.

Changes

• f1-scoreboard/scroll_display.py: Replace reset() with reset_scroll() in both call sites (force_clear path and ScrollDisplay.reset())
• ufc-scoreboard/scroll_display.py: Same fix for consistency (prevents same error if UFC uses reset)
• f1-scoreboard manifest: Bump version to 1.2.3, sync plugins.json

Type of Change

• Bug fix (non-breaking change)

Testing

• Verified no remaining scroll_helper.reset() calls in touched plugins
• Registry sync completes successfully

Made with Cursor

Summary by CodeRabbit

• Updates
  • F1 Scoreboard plugin upgraded to version 1.2.3, compatible with LedMatrix 2.0.0 and later.
  • Plugin metadata and version information updated.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request updates the F1 Scoreboard plugin to version 1.2.3, bumping manifest versions and timestamps accordingly. Additionally, both F1 and UFC Scoreboard plugins are updated to use the new reset_scroll() method instead of the deprecated reset() method from ScrollHelper.

Changes

Cohort / File(s)	Summary
Plugin Manifests plugins.json, plugins/f1-scoreboard/manifest.json	Version bump to 1.2.3 for F1 Scoreboard plugin. Updated last_updated timestamps from 2026-02-25/02 to 2026-03-08. Added new version entry in manifest versions array for 1.2.3 with ledmatrix_min 2.0.0.
ScrollDisplay API Migration plugins/f1-scoreboard/scroll_display.py, plugins/ufc-scoreboard/scroll_display.py	Replaced calls to ScrollHelper.reset() with ScrollHelper.reset_scroll() in both ScrollDisplay and ScrollDisplayManager reset methods.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix(soccer): use correct ScrollHelper constructor signature #31 — Updates plugin ScrollDisplay code to match changes in the ScrollHelper API across multiple scoreboard plugins.
• fix(vegas): include all games regardless of display mode #30 — Modifies ScrollHelper usage in scoreboards by switching calls from reset() to reset_scroll() in UFC and other scoreboard implementations.
• feat: add Formula 1 Scoreboard plugin #37 — Introduces changes to ScrollDisplay usages that call ScrollHelper.reset_scroll() instead of reset(), directly aligned with the scroll_display.py modifications in this PR.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically identifies the main fix: replacing ScrollHelper.reset() with reset_scroll() to resolve the AttributeError in the F1 plugin.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/f1-scrollhelper-reset-attributeerror

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ChuckBuilds]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@plugins.json`:
- Line 3: The top-level "last_updated" field in plugins.json has been set to
"2026-03-08" which is older than a plugin entry updated on "2026-03-09"; update
the top-level "last_updated" value so it is monotonic (>= the newest plugin
entry date) or re-run the sync that sources it from manifest.json via the
update_registry.py script so the registry timestamp matches the latest plugin
update; ensure you update the "last_updated" key in plugins.json (or regenerate
via update_registry.py) rather than manually setting a past date.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7d2fc319-c37d-4b6a-b588-e944d060acc4

📥 Commits

Reviewing files that changed from the base of the PR and between 7c143a2 and 3d9398a.

📒 Files selected for processing (4)

• plugins.json
• plugins/f1-scoreboard/manifest.json
• plugins/f1-scoreboard/scroll_display.py
• plugins/ufc-scoreboard/scroll_display.py

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Keep the registry timestamp monotonic.

Line 3 now sets the top-level last_updated to 2026-03-08, but this file already contains a plugin entry updated on 2026-03-09. If store clients key refreshes off the registry timestamp, moving it backward can make this update look stale.

🩹 Suggested fix

-  "last_updated": "2026-03-08",
+  "last_updated": "2026-03-09",

Based on learnings, "The plugins.json registry file is the source of truth for the Plugin Store and is automatically synced from manifest.json by the update_registry.py script via pre-commit hook".

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	"last_updated": "2026-03-08",
	"last_updated": "2026-03-09",

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@plugins.json` at line 3, The top-level "last_updated" field in plugins.json
has been set to "2026-03-08" which is older than a plugin entry updated on
"2026-03-09"; update the top-level "last_updated" value so it is monotonic (>=
the newest plugin entry date) or re-run the sync that sources it from
manifest.json via the update_registry.py script so the registry timestamp
matches the latest plugin update; ensure you update the "last_updated" key in
plugins.json (or regenerate via update_registry.py) rather than manually setting
a past date.