Skip to content

fix(f1): resolve ScrollHelper.reset AttributeError #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChuckBuilds merged 1 commit into from
Mar 21, 2026
Merged

fix(f1): resolve ScrollHelper.reset AttributeError #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"version": "1.0.0",
"last_updated": "2026-03-09",
"last_updated": "2026-03-08",
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Keep the registry timestamp monotonic.

Line 3 now sets the top-level last_updated to 2026-03-08, but this file already contains a plugin entry updated on 2026-03-09. If store clients key refreshes off the registry timestamp, moving it backward can make this update look stale.

🩹 Suggested fix 
-  "last_updated": "2026-03-08",
+  "last_updated": "2026-03-09",

Based on learnings, "The plugins.json registry file is the source of truth for the Plugin Store and is automatically synced from manifest.json by the update_registry.py script via pre-commit hook".

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"last_updated": "2026-03-08",
"last_updated": "2026-03-09",
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@plugins.json` at line 3, The top-level "last_updated" field in plugins.json
has been set to "2026-03-08" which is older than a plugin entry updated on
"2026-03-09"; update the top-level "last_updated" value so it is monotonic (>=
the newest plugin entry date) or re-run the sync that sources it from
manifest.json via the update_registry.py script so the registry timestamp
matches the latest plugin update; ensure you update the "last_updated" key in
plugins.json (or regenerate via update_registry.py) rather than manually setting
a past date.

"plugins": [
{
"id": "hello-world",
Expand Down Expand Up @@ -644,10 +644,10 @@
"plugin_path": "plugins/f1-scoreboard",
"stars": 0,
"downloads": 0,
"last_updated": "2026-02-25",
"last_updated": "2026-03-08",
"verified": true,
"screenshot": "",
"latest_version": "1.2.2"
"latest_version": "1.2.3"
},
{
"id": "pga-tour-leaderboard",
Expand Down
9 changes: 7 additions & 2 deletions plugins/f1-scoreboard/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"id": "f1-scoreboard",
"name": "F1 Scoreboard",
"version": "1.2.2",
"version": "1.2.3",
"author": "ChuckBuilds",
"class_name": "F1ScoreboardPlugin",
"entry_point": "manager.py",
Expand Down Expand Up @@ -29,6 +29,11 @@
"f1_calendar"
],
"versions": [
{
"version": "1.2.3",
"ledmatrix_min": "2.0.0",
"released": "2026-03-08"
},
{
"version": "1.2.2",
"ledmatrix_min": "2.0.0",
Expand All @@ -50,7 +55,7 @@
"released": "2026-02-17"
}
],
"last_updated": "2026-03-02",
"last_updated": "2026-03-08",
"stars": 0,
"downloads": 0,
"verified": true,
Expand Down
4 changes: 2 additions & 2 deletions plugins/f1-scoreboard/scroll_display.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def display_scroll_frame(self, force_clear: bool = False) -> bool:
return True

if force_clear:
self.scroll_helper.reset()
self.scroll_helper.reset_scroll()

self.scroll_helper.update_scroll_position()
visible = self.scroll_helper.get_visible_portion()
Expand All @@ -145,7 +145,7 @@ def display_scroll_frame(self, force_clear: bool = False) -> bool:
def reset(self):
"""Reset scroll position to beginning."""
if self.scroll_helper:
self.scroll_helper.reset()
self.scroll_helper.reset_scroll()

def is_prepared(self) -> bool:
"""Check if content has been prepared for scrolling."""
Expand Down
2 changes: 1 addition & 1 deletion plugins/ufc-scoreboard/scroll_display.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,4 +386,4 @@ def reset(self) -> None:
self._vegas_content_items = []
self._frame_count = 0
if self.scroll_helper:
self.scroll_helper.reset()
self.scroll_helper.reset_scroll()