Conversation
- permit_all 에서 public_api 분리
fix : 공개api (swagger, auth) 에서 토큰 검증요구 에러
Contributor
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthrough보안 구성에 PublicApiProperties를 도입하여 공개 API 경로를 설정으로 관리하고, SecurityConfig와 JwtAuthenticationFilter에 이를 주입해 필터 흐름에서 공개 경로를 조기 우회하도록 변경했습니다. 리소스 하위모듈 커밋 해시가 갱신되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant C as Client
participant F as JwtAuthenticationFilter
participant P as PermitAllProperties
participant A as PublicApiProperties
participant J as JwtService
participant S as SecurityContext
participant H as Downstream Handler
C->>F: HTTP Request
F->>P: isPermitAll(requestURI)?
alt PermitAll
note over F,H: 공개 경로(permitAll) → 인증 우회
F-->>H: chain.doFilter
else Not PermitAll
F->>A: isPublicApi(requestURI)?
alt Public API
note over F,H: 공개 API(public-api) → 인증 우회
F-->>H: chain.doFilter
else Protected
F->>J: parse/validate JWT
alt Token 유효
F->>S: set Authentication
F-->>H: chain.doFilter
else Token 없음/무효
note over F: 인증 미설정 상태로 진행 또는 에러 처리(구현에 따름)
F-->>H: chain.doFilter / error
end
end
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
#266
#263
📝 작업 내용
fix : 공개api (swagger, auth) 에서 토큰 검증요구 에러
Summary by CodeRabbit
신기능
개선
기타