Skip to content

#F01 Footer Content & Styling #53#74

Merged
stefdworschak merged 10 commits intoCode-Institute-Community:masterfrom
JimLynx:footer-content
Oct 18, 2020
Merged

#F01 Footer Content & Styling #53#74
stefdworschak merged 10 commits intoCode-Institute-Community:masterfrom
JimLynx:footer-content

Conversation

@JimLynx
Copy link
Contributor

@JimLynx JimLynx commented Oct 17, 2020

  • Created footer.html layout & Styled with CSS
  • Created templates html page links
  • Created basic views and paths for all links in footer

Views/Paths/templates created for:

  1. Privacy Policy
  2. Plagiarism Policy
  3. FAQ
  4. Judging Criteria
  5. Useful Resources

Testing:

  • Passed CSS through CSS Validation and no issues present
  • Passed HTML through HTML Validator and no issues present
  • Clicked on all links to ensure they open in a new tab and presented as expected

IMAGES:

  1. Footer
    Footer

  2. Link template example
    template

@TravelTimN TravelTimN linked an issue Oct 17, 2020 that may be closed by this pull request
Copy link
Collaborator

@TravelTimN TravelTimN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JimLynx
Looks great - there are some changes to be adjusted below.
Looks like you have a Merge Conflict to be updated as well, with the .gitignore file.
Not mentioned below on the Review, are the spaces on your CSS file.
Make sure you keep it consistent, which I believe is 4-spaces, whereas your extension looks to be adding 3-spaces only.

@JimLynx
Copy link
Contributor Author

JimLynx commented Oct 17, 2020

All changed in review completed and pushed updated files to footer-content branch
@TravelTimN @stefdworschak

@stefdworschak
Copy link
Member

@JimLynx could you just merge the newest changes from master and resolve the merge conflict please?

@JimLynx
Copy link
Contributor Author

JimLynx commented Oct 18, 2020

All good @stefdworschak ?

@TravelTimN
Copy link
Collaborator

The CSS file looks to be entirely modified again - something with an extension that you might want to be mindful of, @JimLynx ... other than that, let's see what @stefdworschak has to say.

Copy link
Member

@stefdworschak stefdworschak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JimLynx as @TravelTimN mentioned I would check your extensions again, but I don't really see a difference between the two versions. So it should be fine.

@stefdworschak stefdworschak merged commit 3bd10f1 into Code-Institute-Community:master Oct 18, 2020
@stefdworschak stefdworschak added the hacktoberfest-accepted Accepted PR during Hacktoberfest label Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Accepted PR during Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

#T01 Footer Content & Styling

3 participants

Comments