change the layout for the Footer and style it

[nahed2019]

Description:

Just rearrange the layout of footer and style it.
this first try I just want to learn how we can contribute.

Related Issue:

Link to the related Issue

Configuration instructions:

List any non-trivial configuration instructions (if any)

**Testing:

Explain what kind of testing was performed and list any testing instructions (if needed)

Screenshots:

Add any screenshots (if needed)

Additional Information:

Any other information that is needed

[Eventyret]

Would suggest to target with id or class instead of using elements like h4 if this changes to anything else the CSS breaks.

[Eventyret]

<hr> are normally deprecated so would suggest using CSS to create the border

[stefdworschak]

@nahed2019 could you make the changes Simen requested and tag me in this once done to approve it?

[nahed2019]

Yes, sure I will do it today night thanks.

…

On Tue, Oct 20, 2020, 11:29 Stefan Dworschak ***@***.***> wrote: ***@***.**** requested changes on this pull request. @nahed2019 <https://github.com/nahed2019> could you make the changes Simen requested and tag me in this once done to approve it? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#86 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AND7XGJZ2POQWDPHM4OX2IDSLVKA5ANCNFSM4SXDN7VA> .

[auxfuse]

Can I ask why we are restyling the Footer that has already been a previously approved PR request and was structured inline with the CI template? The orange icons are garishly poor against the native grey background theme color and the way it was prior was much better in terms of UX to appeal to those users who may have a visual impairments especially around color contrast.

Is this not essentially a duplicate PR of works already commited and merged.

@Eventyret @stefdworschak @nahed2019 This PR request I am talking about btw was PR: #F01 Footer Content & Styling #53 #74

[nahed2019]

*@stefdworschak* changes were done, but I don't know if it is done in the correct way. Thanks for giving me a chance to learn new things.

…

On Tue, Oct 20, 2020, 11:29 Stefan Dworschak ***@***.***> wrote: ***@***.**** requested changes on this pull request. @nahed2019 <https://github.com/nahed2019> could you make the changes Simen requested and tag me in this once done to approve it? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#86 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AND7XGJZ2POQWDPHM4OX2IDSLVKA5ANCNFSM4SXDN7VA> .

[stefdworschak]

@nahed2019 sorry for only getting back to you on this now, but after some consideration here I would like to leave the design on the footer as it is. I would suggest that we close the PR and maybe you can focus on styling some of the pages used by all_auth (see screenshot).

[nahed2019]

*@stefdworschak* Thanks for your reply, I will check if I can help with another issue, I just wanted to learn how to work with a team, and that was very helpful and useful for me. When I made the last update I couldn't attach the screenshot, if you can check it and let me know if I did it in the correct way. The social link is just hovering with orange color. [image: image.png] 

…

On Wed, Oct 21, 2020 at 6:51 PM Stefan Dworschak ***@***.***> wrote: @nahed2019 <https://github.com/nahed2019> sorry for only getting back to you on this now, but after some consideration here I would like to leave the design on the footer as it is. I would suggest that we close the PR and maybe you can focus on styling some of the pages used by all_auth (see screenshot). [image: image] <https://user-images.githubusercontent.com/31205982/96749588-eadf0680-13c2-11eb-9788-fd5e2ca4b50c.png> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#86 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AND7XGJXULMIDI7JBI3NSA3SL4GSFANCNFSM4SXDN7VA> .