Do not count validators who do not proposed in additional reward calculation#1982
Merged
majecty merged 1 commit intoCodeChain-io:masterfrom Aug 12, 2020
Merged
Conversation
…ulation In the additional reward calculation, we divide a validator's missed precommits by the validator's proposed count. Some validators may not proposed in a term. To avoid "divide by zero" error, ignore the validators who did not proposed any block.
sgkim126
approved these changes
Aug 12, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the additional reward calculation, we divide a validator's missed precommits by the validator's proposed count. Some validators may not proposed in a term. To avoid "divide by zero" error, ignore the validators who did not proposed any block.
The "divide by zero" error happens after this commit: 79322e1
The 2.x releases do not have the commit. Only the master branch has the problem.