Skip to content

Do not count validators who do not proposed in additional reward calculation #1982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
majecty merged 1 commit into from
Aug 12, 2020
Merged

Do not count validators who do not proposed in additional reward calculation #1982

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/src/consensus/tendermint/engine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,6 +471,7 @@ fn give_additional_rewards<F: FnMut(&Address, u64) -> Result<(), Error>>(
) -> Result<(), Error> {
let sorted_validators = work_info
.into_iter()
.filter(|(_, work)| work.proposed > 0)
.map(|(address, info)| (address, Ratio::new(info.missed, info.proposed)))
// When one sees the Ratio crate's Order trait implementation, he/she can easily realize that the
// comparing routine is erroneous. It inversely compares denominators when the numerators are the same.
Expand Down