Remove Custom transactions and make the stake transactions top level#149
Merged
majecty merged 3 commits intoCodeChain-io:masterfrom Apr 1, 2020
Merged
Remove Custom transactions and make the stake transactions top level#149majecty merged 3 commits intoCodeChain-io:masterfrom
majecty merged 3 commits intoCodeChain-io:masterfrom
Conversation
sgkim126
changed the title
Contributor
Author
|
|
sgkim126
force-pushed
the
stake
branch
5 times, most recently
from
1816016 to
a823bda
Compare
majecty
requested changes
Mar 31, 2020
core/src/miner/mem_pool_types.rs
Outdated
| // FIXME | ||
| 0 | ||
| } | ||
| _ => self.min_custom_transaction_cost, |
There was a problem hiding this comment.
How about creating match cases for each Actions Instead of using _ pattern?
If we use _ pattern in our code, it is hard to find the match expression when we add a new enum variant in the Action.
However, if this code will be removed and all transactions will be moved to the Module level, it's good to use _ pattern here for temporary.
Contributor
Author
core/src/codechain_machine.rs
Outdated
| // FIXME | ||
| 0 | ||
| } | ||
| _ => params.min_custom_transaction_cost(), |
There was a problem hiding this comment.
Will you change the name min_custom_transaction_cost later?
majecty
approved these changes
Mar 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It closes #38