Introduce DoubleVoteHandler#291
Merged
sgkim126 merged 5 commits intoCodeChain-io:masterfrom Mar 30, 2020
Merged
Conversation
This was referenced Mar 28, 2020
Contributor
Author
added 5 commits
March 30, 2020 12:00
And this commit renames another Deposit type which means the quantity of deposit to DepositQuantity.
majecty
approved these changes
Mar 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch removes stake related implementations from the core crate.
The jobs that StakeHandler did are implemented in the state crate. The only thing that the state crate cannot handle is
ReportDoubleVotebecause it's hard coupled with the consensus. So this patch introducesDoubleVoteHandler. I think a similar handler will be used even after the module separation.