Remove HitHandler and replace ActionHandler to StakeHandler#283
Merged
majecty merged 2 commits intoCodeChain-io:masterfrom Mar 30, 2020
Merged
Remove HitHandler and replace ActionHandler to StakeHandler#283majecty merged 2 commits intoCodeChain-io:masterfrom
majecty merged 2 commits intoCodeChain-io:masterfrom
Conversation
added 2 commits
March 27, 2020 00:07
The handler is for testing custom actions. Since the Foundry will not support the custom actions, this handler is not necessary. The ActionHandler will be removed after moving the stake states to the top level.
This commit deplecates the action handlers and introduce StakeHandler to handle the stake transactions. The handler id in RPCs and custom transactions remain to make the JavaScript SDK compatible.
sgkim126
changed the title
Contributor
Author
majecty
approved these changes
Mar 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hit handler is for testing custom actions. Since the Foundry will not support the custom actions, this handler is not necessary.
This PR also replaces the ActionHandler to the StakeHandler, but the handler id remains for SDK compatibility. Internally, the id is not used the transaction and RPC methods have the id fields.