Assign unbound port numbers in test instances#255
Merged
byeongjee merged 3 commits intoCodeChain-io:masterfrom Mar 16, 2020
Merged
Assign unbound port numbers in test instances#255byeongjee merged 3 commits intoCodeChain-io:masterfrom
byeongjee merged 3 commits intoCodeChain-io:masterfrom
Conversation
byeongjee
force-pushed
the
use.unbound.port
branch
2 times, most recently
from
453f262 to
63b461f
Compare
byeongjee
force-pushed
the
use.unbound.port
branch
2 times, most recently
from
5524dee to
5f99c51
Compare
majecty
previously approved these changes
Mar 12, 2020
Port numbers assigned to test Foundry instances should be unbound. If the port is already in use, the test will fail, which is not an intended behavior.
byeongjee
force-pushed
the
use.unbound.port
branch
from
5f99c51 to
1112ac3
Compare
majecty
approved these changes
Mar 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #254
Port numbers assigned to test Foundry instances should be unbound.
If the port is already in use, the test will fail, which is not an intended behavior.