original data in hooks

[ahoyahoy]

Environment

latest

Reproduction

playground

Describe the bug

Hi there,

I'm not sure if it is bug.
How to get original data in updating hook?

$getOriginal() works as I expected. After changing .name I can get original name.

In updating hook are model and record args.
Reading model.$getOriginal in this hook return new data.
Second arg record is also new, thus I don't even understand its purpose, when I can get same data with model.$toJson()

So is it bug or how can I get previous data during update proces?

Additional context

No response

Logs

No response

[CodeDredd]

@ahoyahoy Good point ! ... i looked into the code and some logic error. I am hydrating the model with the new data and then i am passing it to the hook which results in this behaviour. Going to change it. So that record is the new plan data and the model if it already exists will be updated after the hook is called.

[ahoyahoy]

@CodeDredd
I'm glad you're alive :)
I appreciate your work! Thank you

[CodeDredd]

@ahoyahoy Thanks a lot! And i apprecate your support for me a lot. Saw the update of it. Many thanks! ❤️

[ahoyahoy]

Hi @CodeDredd
I don't like to bother you, but do you have any time frame for when it might be fixed? :)

[CodeDredd]

@ahoyahoy Sorry for being so long away. I had to focus on some real life issues.

You can check the change already with the new edge channel release if you like:
https://pinia-orm.codedredd.de/guide/getting-started/quick-start#edge-channel

[daniser]

@CodeDredd I guess my problem is related to this one so I won't create new issue.
$isDirty method always returns false when called from ...ing (before) hooks, i.e. $getOriginal return already updated data - as pointed by @ahoyahoy.
Therefore there's no easy way to know if model really changed or not.
"After" hooks works the same way, but at least it can be understandable.
P.S. checked out edge channel release - second argument now holds old value, but $isDirty and $getOriginal calls on model still returns wrong results.
P.P.S. For now I'm using this workaround (with deep equals function stolen from Pinia ORM source):

static updating(person: Person, record?: Record<string, any>) {
    const dirty = !equals(record, person.$getAttributes())
    // ...
}

[CodeDredd]

@daniser fixed it. Now i also changed again back second param to be the data which is passed to the model. (like before)
So to get the old data in updating hooks you need now to call $getOriginal()