Skip to content

Conversation

@CodeDredd
Copy link
Owner

@CodeDredd CodeDredd commented May 4, 2024

πŸ”— Linked issue

closes #1707

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The hooks saving, creating, updating, saved, created & updated had a second param record which was wrongly already the new data instead of the old one. The new data is already saved in the model param.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@CodeDredd CodeDredd changed the title fix(pinia-orm-1707): saving, updating hooks second param had wrong values fix(pinia-orm): saving, updating hooks second param had wrong values May 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 4, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 99.71%. Comparing base (34348a5) to head (d573aec).

Files Patch % Lines
packages/pinia-orm/src/query/Query.ts 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1826      +/-   ##
==========================================
+ Coverage   99.67%   99.71%   +0.03%     
==========================================
  Files          87       87              
  Lines        5934     5934              
  Branches      508      509       +1     
==========================================
+ Hits         5915     5917       +2     
+ Misses         17       14       -3     
- Partials        2        3       +1     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

original data in hooks

3 participants