✨ Use the option in settings to either use or hide the theme background color

[austincondiff]

Is your feature request related to a problem? Please describe.

The "Use theme background" checkbox in Settings does not work.

Describe the solution you'd like

Use the "Use theme background" option in settings to either use or hide the theme background color.

When unchecked, the theme background color will be .clear showing through to the editor background behind CodeEditTextView.

In dark mode, the editor background should be EffectView(.underPageBackground) and in light mode it should be EffectView(.contentBackground).

This same should also apply to the terminal, this checkbox does not exist in the terminal tab, so it will need to be added underneath, "Always use dark terminal appearance"

[neil-ptr]

I'll try my hand at this! It seems there might be some changes in the CodeEditTextView package needed for this as well

[lukepistrol]

@neilZon I assigned you to this issue. If there are changes needed in CodeEditTextView please just create a pull request and link this issue.

[neil-ptr]

Screen.Recording.2023-01-18.at.4.40.50.PM.mov

This is what I have so far for just the code editor part but I'm not too sure about the light theme with the "use theme background" unchecked since some of the text blends into the background, unless I got something wrong from the issue description so feedback would be greatly appreciated @austincondiff @lukepistrol :)
(also I noticed the rest of the editor like the sidebar doesn't change color when going to light theme)

[austincondiff]

This is great so far! We might have a boolean in our theme config files isDarkTheme that when true and when using a light appearance, we might manually set the background to black. And vise-versa, if using a dark appearance, we might force a white background if isDarkTheme is set to false in the applied theme.

@lukepistrol do you have any thoughts around this?

[lukepistrol]

@austincondiff the theme already has a key called appearance which is an enum ThemeType of either .dark or .light

[austincondiff]

Perfect, we can use that then!