use theme background

[neil-ptr]

Description

Passes theme background preference bindings to TerminalEmulatorView and CodeEditTextView to change their backgrounds based on these preferences.

Related Issue

• closes ✨ Use the option in settings to either use or hide the theme background color #982
• depends on https://github.com/CodeEditApp/CodeEditTextView/pull/123

Checklist

• I read and understood the contributing guide as well as the code of conduct
• My changes generate no new warnings
• My code builds and runs on my machine
• I documented my code
• Review requested

Screenshots

With a dark system appearance, the light editor themes will default to a white background if the use theme background button is toggled off due to some of the text blending into the background and vice versa for the light system appearance with dark editor themes as mentioned in #982 (comment)

Screen.Recording.2023-01-19.at.11.34.22.PM.mov

Screen.Recording.2023-01-19.at.11.32.55.PM.mov

[neil-ptr]

It seems that https://github.com/CodeEditApp/CodeEditTextView/pull/123 needs to be merged and the CodeEditTextView package in this project to be updated before the tests can pass

[lukepistrol]

Please update CodeEditTextView to 0.3.4

• https://github.com/CodeEditApp/CodeEditTextView/releases/tag/0.3.4

[austincondiff]

This same should also apply to the terminal, this checkbox does not exist in the terminal tab, so it will need to be added underneath, "Always use dark terminal appearance"

In the terminal tab, it looks like you repurposed the "Always use dark terminal appearance" instead of adding a "Use theme background" checkbox underneath it. Please correct this.

The "Always use dark terminal appearance" should restrict the terminal to only using dark themes, even when in light mode.

The "Use theme background" checkbox should enable or disable the theme background in the terminal.

[neil-ptr]

This same should also apply to the terminal, this checkbox does not exist in the terminal tab, so it will need to be added underneath, "Always use dark terminal appearance"

In the terminal tab, it looks like you repurposed the "Always use dark terminal appearance" instead of adding a "Use theme background" checkbox underneath it. Please correct this.

The "Always use dark terminal appearance" should restrict the terminal to only using dark themes, even when in light mode.

The "Use theme background" checkbox should enable or disable the theme background in the terminal.

Ohh I misread that, I'll fix it 👍

[austincondiff]

Looks good, nice work!