Skip to content

Add text zoom shortcut #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Wouter01 merged 2 commits into from
Mar 23, 2023
Merged

Add text zoom shortcut #1191

Wouter01 merged 2 commits into from
Mar 23, 2023

Conversation

@luah5
Copy link
Member

@luah5 luah5 commented Mar 23, 2023 •
edited
Loading

Description

This PR adds support for zooming in and zooming out and disables the customize toolbar button with .disabled.

NOTE: Xcode has a zoom button in the WindowCommands CommandView but since it only has one zoom button and the linked issue suggests we have 2 keybinds similar to safari, i have made 2 keybindings.
`

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

shot.1.mov

shot 2

Wouter01
Wouter01 approved these changes Mar 23, 2023
View reviewed changes
@Wouter01 Wouter01 enabled auto-merge (squash) March 23, 2023 13:26
@Wouter01 Wouter01 merged commit f493eaf into CodeEditApp:main Mar 23, 2023
@luah5 luah5 mentioned this pull request Mar 25, 2023
Closed
luah5 added a commit to luah5/CodeEdit that referenced this pull request Mar 28, 2023
@luah5
add terminal zoom in/out (building on top of CodeEditApp#1191)
5261df0
@luah5 luah5 mentioned this pull request Mar 28, 2023
Merged
6 tasks
austincondiff pushed a commit that referenced this pull request Mar 29, 2023
@luah5
Add terminal zoom in/out (building on top of #1191) (#1209)
dd8fce2 
* add terminal zoom in/out (building on top of #1191)

* respond to @austincondiff's review

* make variables private

* fix logic

* fix @matthijseikelenboom's review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xWDG 0xWDG 0xWDG approved these changes

@Wouter01 Wouter01 Wouter01 approved these changes

Assignees

@luah5 luah5

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

✨ Command plus and minus keybinding to adjust font size.

3 participants

@luah5 @0xWDG @Wouter01