Account Setting SSH Keys Picker #1249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… account settings
… new ssh key...). Added the non-working view for create a new ssh key.
…now using account.sshKey instead of settings.accounts.sshKey
matthijseikelenboom
previously approved these changes
May 1, 2023
6 tasks
0xWDG
previously approved these changes
May 3, 2023
austincondiff
dismissed stale reviews from 0xWDG and matthijseikelenboom
via
d07d52f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the SSH Keys picker functional in account settings by finding ssh keys in ~/.ssh and adding them to the menu.
Related Issues
Checklist
Enable ssh key creation(will create a separate issue for this)Allow users to browse to ssh keys in a custom location(will create a separate issue for this)Screenshots